This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add to Cart with options block > Remove opinionated style for the price list in grouped products. #9988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the Add to Cart with Options block.
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -72 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
5 tasks
rrennick
reviewed
Jun 26, 2023
There was a problem hiding this comment.
@nefeline Thanks for the quick turn around on this. I created woocommerce/woocommerce#38945 to address removing the same CSS for the core template.
albarin
approved these changes
Jun 27, 2023
Aljullu
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
LGTM to me as well. Thanks @nefeline for looking into this!
❗ Important note: with this change, we are now diverging from the classic template for grouped products (which is still rendering these prices with a large font size): so upstream changes are possibly required to ensure this style is consistent across the board. By reading through the issue (#9972), I believe what we have here is the expectation in the long term, but tagging @Aljullu @rrennick for your input/thoughts (also, please see this comment).
Good point. I agree it makes sense fixing it in both.
nefeline
deleted the
fix/add-to-cart-with-options-block-remove-opinionated-css
branch
opr
added
type: bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the price text doesn't appear larger in grouped products.
❗ Important note: with this change, we are now diverging from the classic template for grouped products (which is still rendering these prices with a large font size): so upstream changes are possibly required to ensure this style is consistent across the board. By reading through the issue (#9972), I believe what we have here is the expectation in the long term, but tagging @Aljullu @rrennick for your input/thoughts (also, please see this comment).
Fixes #9972
Screenshots
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog