This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Single Product Template: fix compatibility layer logic when the blocks aren't wrapped in a group block #9982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
woocommercebot
requested review from
a team and
nefeline
and removed request for
a team
|
Size Change: 0 B Total Size: 1.17 MB ℹ️ View Unchanged
|
…s aren't wrapped in a group block
gigitux
force-pushed
the
9922-single-product-template-compatibility-layer-in-some-cases-only-the-first-block-is-rendered
branch
from
bdcea75 to
d6e7c72
Compare
…layer-in-some-cases-only-the-first-block-is-rendered
nefeline
reviewed
Jun 26, 2023
nefeline
reviewed
Jun 27, 2023
There was a problem hiding this comment.
The code looks good 🎉 ! I just have a question as the test instructions state:
Only the first paragraph block is visible.
But all three paragraphs are visible with the changes made here (which I suspect is the desired outcome of this PR). Can you please confirm?
Yeah! I updated the testing instructions:
Thanks for catching it! |
nefeline
approved these changes
Jun 27, 2023
gigitux
deleted the
9922-single-product-template-compatibility-layer-in-some-cases-only-the-first-block-is-rendered
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #9922. In this PR, I revisit the logic of the Compatibility Layer: It isn't necessary to wrap the blocks inside a div with the class
woocommerceif any block related to the Single Product Template is used. In this way, it has been easier to fix the issue.Fixes #9922
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog