This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
All Reviews block: Fix error when adding the block to a store without reviews #9869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thealexandrelara
added
type: bug
woocommercebot
requested review from
a team and
roykho
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/reviews/reviews-by-category/block.tsx
|
|
Size Change: +4 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
gigitux
added
the
status: blocker
|
Marking this PR as a blocker. Since it is a regression, we must include this PR in 10.5.0 release! |
imanish003
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Hey @thealexandrelara, Thanks for fixing this issue, LGTM 🚀
imanish003
deleted the
fix/9866-error-when-adding-all-reviews-block-to-store-without-reviews
branch
gigitux
pushed a commit
that referenced
this pull request
Jun 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR I fixed an error that was occurring when adding the All Reviews block to a store that has no product reviews.
Walkthrough
🤖 Generated by Copilot at 07c035c
NoReviewsPlaceholdercomponent was called as a function instead of being passed as a prop (link)noReviewsPlaceholderprop inEditorContainerBlockcomponent to accept any component type (link)In this PR I fixed a PropType warning and also solved an error that was occurring when adding the Reviews by Category block to a store that has no product reviews.
Fixes #9866
Accessibility
prefers-reduced-motionOther Checks
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog