This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product by Category block: Fix error when adding the block to a store without reviews #9868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/reviews/all-reviews/block.tsx
|
|
Size Change: +18 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
thealexandrelara
added
type: bug
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
thealexandrelara
changed the title
imanish003
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Hey @thealexandrelara, I have tested the PR and can confirm that it works as expected. Therefore, I'm approving this PR. Great work! 🚀
imanish003
deleted the
fix/9867-error-when-adding-reviews-by-category-block-to-store-without-reviews
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR I fixed a PropType warning and also solved an error that was occurring when adding the Reviews by Category block to a store that has no product reviews.
Walkthrough
🤖 Generated by Copilot at 4d660a5
noReviewsPlaceholderprop inEditorContainerBlockcomponent (link)NoReviewsPlaceholdercomponent as a render prop toEditorContainerBlockcomponent inreviews-by-categoryblock (link)Fixes #9867
Accessibility
prefers-reduced-motionOther Checks
Screenshots
Testing
Automated Tests
User Facing Testing
Steps to reproduce the behavior:
WooCommerce Visibility
Performance Impact
Changelog