This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Peer Dependency: Request 2.88.2 #9827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
changed the title
mikejolley
added
the
type: dependencies
woocommercebot
requested review from
a team and
tarunvijwani
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
|
Just needs your ✅ @tarunvijwani — tests are failing in trunk right now so you can ignore those. |
tarunvijwani
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Thank you for working on it! 🎉
Question: While reviewing the PR, I read about the request nodule: https://www.npmjs.com/package/request
I couldn't locate it anywhere in our code. I tried looking for the string request( but couldn't locate anything. Is it required in Core?
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
|
@tarunvijwani It's a peer dependency; a dependency of another. We include it so the version we defined is used by other dependencies. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forces 2.88.2 of the request peer dependency to ensure 2.88.2 is used. This only affects development builds.