-
Notifications
You must be signed in to change notification settings - Fork 219
Add a default attribute to the pattern if exists #9812
Conversation
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement, thanks @albarin! LGTM, but one small thought: should we use intval()
or esc_attr()
instead of esc_html()
to print the attribute id? What do you think?
Sure, you are right, I just pushed the change, thanks! |
Show more missing on frontend (Gutenberg Block Editor). Appears in the Widget Dashboard section. Fix issue "limit" in attribute-filter-wrapper--stock-filter-wrapper-frontend.js |
Hi there, @Hakenstein, it's not clear to me what exactly you are describing. Would you mind opening a new issue with testing steps so we can investigate it further? Attaching some screenshots would be super helpful. Thanks in advance. |
This PRs gets the current attributes in the store and uses the first one (if any) to render the filters by attribute preview and as default in the filters pattern.
Fixes #7190
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Product Filters
pattern.WooCommerce Visibility
Changelog