Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Release: 10.4.2 #9784

Merged
merged 22 commits into from
Jun 13, 2023
Merged

Release: 10.4.2 #9784

merged 22 commits into from
Jun 13, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 12, 2023 •
edited by tarunvijwani
Loading

Patch release

This is the patch release pull request for WooCommerce Blocks plugin 10.4.2.

Changelog

#### Bug Fixes

- Update the Product Collections: Featured Collections to replace the Unsplash image with a CCO licensed image from Pxhere. ([9766](https://github.com/woocommerce/woocommerce-blocks/pull/9766))
- Update the Featured Category patterns to replace the Unsplash image with a CCO licensed image from Pxhere. ([9765](https://github.com/woocommerce/woocommerce-blocks/pull/9765))
- Update the Product Details patterns to replace the Unsplash images with CCO licensed images from Pxhere. ([9764](https://github.com/woocommerce/woocommerce-blocks/pull/9764))
- Update the Hero Product Split pattern to replace the Unsplash image with a CCO licensed image from Pxhere. ([9762](https://github.com/woocommerce/woocommerce-blocks/pull/9762))
- Update the Hero Product Chessboard pattern to replace the Unsplash image with a CCO licensed image from Pxhere. ([9761](https://github.com/woocommerce/woocommerce-blocks/pull/9761))
- Update the banner pattern to replace the Unsplash image with a CCO licensed image from Pxhere. ([9760](https://github.com/woocommerce/woocommerce-blocks/pull/9760))
- Fix error on clearing customizations on Woo Templates that prevented WooCommerce Classic Template block from being displayed. ([9759](https://github.com/woocommerce/woocommerce-blocks/pull/9759))

Communication

Prepared Updates

Please leave a comment on this PR with links to the following:

  • Release announcement (announcement post on developer.woocommerce.com published after release).

  • Happiness engineering or Happiness/Support (if special instructions needed).

  • Relevant developer documentation (if applicable).

Quality

This section is for things related to quality around the release.

  • Testing Instructions are included in this PR

  • Any performance impacts are documented.

🚀 This pull request was generated by the automations bot triggered by the creation of the branch: release/10.4.2. cc @tarunvijwani

@github-actions
Copy link
Contributor Author

github-actions bot commented Jun 12, 2023 •
edited by tarunvijwani
Loading

Patch release steps

The release pull request has been created! This checklist is a guide to follow for the remainder of the patch release process. You can check off each item in this list once completed.

  • Checkout the release branch locally.

Initial Preparation

  • Close the milestone of the release you are going to ship. That will prevent newly approved PRs to be automatically assigned to that milestone.
  • Check that the release automation correctly added the changelog to readme.txt
  • Ensure you pull your changes from the remote, since GitHub Actions will have added new commits to the branch.
    • Check the version and date in the changelog section within readme.txt, e.g. = 10.4.2 - YYYY-MM-DD =
    • Check the changelog matches the one in the pull request description above.
  • Run npm run change-versions to update the version numbers in several files. Write the version number you are releasing: 10.4.2.
  • Update compatibility sections (if applicable).
  • Cherry-pick into the release branch all fixes that need to be included in this release (assuming they were merged into trunk).
  • Push above changes to the release branch.

Create the Testing Notes

  • Run npm ci
  • Run npm run package-plugin:deploy. This will create a zip of the current branch build locally.
  • Create the testing notes for the release.
    • For each pull request that belongs to the current release, grab the User Facing Testing notes from the PR's description. Be sure that the Do not include in the Testing Notes is not flagged checkbox is unchecked.
    • Add the notes to docs/internal-developers/testing/releases
    • Update the docs/internal-developers/testing/releases/README.md file index.
  • Copy a link to the release zip you created earlier into the testing notes. To generate the link you can upload the zip as an attachment in a GitHub comment and then just copy the path (without publishing the comment).
  • Commit and push the testing docs to the release branch.
  • Smoke test built release zip using the testing instructions you created:
    • Test in a clean environment, e.g. Jurassic.Ninja site.
    • Test existing WooCommerce Blocks content works correctly after update (no block validation errors).
    • Test to confirm blocks are available and work correctly in oldest supported WordPress version (e.g. 5.3).
    • Confidence check - check blocks are available and function.
    • Test to confirm new features/fixes are working correctly.
    • Test any UI changes in mobile and desktop views.
    • Smoke test – test a cross section of core functionality.
  • Ask the porters of Rubik and Kirigami to smoke test the built release zip as well and to approve the PR if everything looks good.

Each porter is responsible for testing the PRs that fall under the focus of their own team. Shared functionality should be tested by both porters. This means that the Rubik porter will mostly test checkout blocks and Store API endpoints, while the Kirigami porter will test the product related blocks and Store API endpoints.

  • If all PRs are testing as expected, continue with the release.
  • If one or more PRs are not testing as expected: ping the PR authors and the porter of the relevant team and ask them if the change is a release blocker or not (you can also ping the team lead if any of them is not available). In general, if it's not a regression or there is no product/marketing reason why that PR is a blocker, all other PRs should default to not being blockers.
    • If there are blockers: stop the release and ask the PR author to fix them. If the PR author is AFK, ping the porter of their team.
    • If some PRs are not testing as expected but they are not blockers: revert the relevant commits, remove the changes from testing steps and changelog, open an issue (or reopen the original one) and proceed with the release.
    • If minor issues are discovered during the testing, each team is responsible for logging them in Github.

Push the button - Deploy

  • Execute npm run deploy
    • ALERT: This script will ask you if this release will be deployed to WordPress.org. You should only answer yes for this release if it's the latest release and you want to deploy to WordPress.org. Otherwise, answer no. If you answer yes, you will get asked additional verification by the npm run deploy script about deploying a patch release to WordPress.org.

If this release is deployed to WordPress.org

  • An email confirmation is required before the new version will be released, so check your email in order to confirm the release.
  • Edit the GitHub release and copy changelog into the release notes.
  • The #woo-blocks-repo slack instance will be notified about the progress with the WordPress.org deploy. Watch for that. If anything goes wrong, an error will be reported and you can followup via the GitHub actions tab and the log for that workflow.
  • After the wp.org workflow completes, confirm the following
    • Confirm svn tag is correct, e.g. 10.4.2
    • Changelog, Version, and Last Updated on WP.org plugin page is correct.
    • Confirm WooCommerce.com plugin page is updated. Note: this can take several hours, feel free to check it the following day.
    • Download zip and smoke test.
    • Test updating plugin from previous version.

After Deploy

  • Port to trunk the changes to the changelog, testing steps and required versions that you did in the previous steps. You can do so copy-and-pasting the changes in a new commit directly to trunk, or cherry-picking the commits that introduced those changes.
  • Update the schedules p2 with the shipped date for the release (PdToLP-K-p2).
  • Edit the GitHub milestone of the release you just shipped and add the current date as the due date (this is used to track ship date as well).

Pull request in WooCommerce Core for Package update

This only needs done if the patch release needs to be included in WooCommerce Core. Reviewing and merging the PR is your team's responsibility, except in the case of Fix Release Request. In this case, the WooCommerce release manager reviews and merges the PR.

  • Create a pull request for updating the package in WooCommerce core (based off of the WooCommerce core release branch this is deployed for).

    • Set the base branch (the branch that your PR will be merged into) to the correct one. It must be:

      • trunk if the WC Blocks version you are releasing is higher than the one in core (you can find the current WC Blocks version in core in plugins/woocommerce/composer.json)
      • release/x.y if the WC Blocks version in core is higher than the one you are releasing (x.y must be the version of WC core that will include the version of WC Blocks you are releasing)

    • The content for the pull release can follow this example.

      • Increase the version of woocommerce/woocommerce-blocks in the plugins/woocommerce/composer.json file

      • Inside plugins/woocommerce/, run composer update woocommerce/woocommerce-blocks and make sure composer.lock was updated

      • Run pnpm --filter=woocommerce changelog add to create a new changelog file similar to this one plugins/woocommerce/changelog/update-woocommerce-blocks-7.4.1. The file will be auto-generated with your answers. For the Significance entry we’ll always use patch for WC Blocks patch releases:

        Significance: patch
Type: update

Update WooCommerce Blocks to 10.4.2

    • The PR description can follow this example.

      • It lists all the WooCommerce Blocks versions that are being included since the last version that you edited in plugins/woocommerce/composer.json. Each version should have a link for the Release PR, Testing instructions and Release post (if available).
      • The changelog should be aggregated from all the releases included in the package bump and grouped per type: Enhancements, Bug Fixes, Various etc. This changelog will be used in the release notes for the WooCommerce release. That's why it should only list the PRs that have WooCoomerce Core in the WooCommerce Visibility section of their description. Don't include changes available in the feature plugin or development builds.

  • Build WC core from that branch with pnpm run --filter='woocommerce' build (you might need to install the dependencies first) and:

    • Make sure the correct version of WC Blocks is being loaded. This can be done testing at least one of the testing steps from the release.
    • Complete the Smoke testing checklist.

  • Verify and make any additional edits to the pull request description for things like: Changelog to be included with WooCommerce core, additional communication that might be needed elsewhere, additional marketing communication notes that may be needed, etc.

    • Assign the corresponding WC version milestone to the PR
    • After the checklist is complete and the testing is done, select the porter of your team to review the PR. Once approved, make sure you merge the PR.

  • Make sure you join the #woo-core-releases Slack channel to represent Woo Blocks for the release of WooCommerce core this version is included in.

Publish Posts

You only need to post public release announcements and update relevant public facing docs if this patch release is deployed to WP.org. Otherwise, you can skip this section.

  • Post release announcement on WooCommerce Developer Blog.
    • Ping porters from each team to know which changelog entries need to be highlighted. Ask them to write a short text and optionally provide a screenshot. They can use previous posts for inspiration, we usually try to highlight new features or API changes.
    • Ensure the release notes are included in the post verbatim.
    • Don't forget to use category WooCommerce Blocks Release Notes for the post.
  • Announce the release internally (#woo-announcements slack).
  • Go through the description of the release pull request and edit it to update all the sections and checklist instructions there.
  • Merge this PR into the base branch: release/x.y.0.
🚀 This comment was generated by the automations bot triggered by the creation of the branch: release/10.4.2. cc @tarunvijwani

@tarunvijwani tarunvijwani mentioned this pull request Jun 12, 2023
Closed
5 tasks
albarin and others added 11 commits June 12, 2023 10:26
@albarin
Update Hero Product 3-split pattern image
f40145a
@danielwrobert
Update Banner Pattern To Replace Unsplash Image (#9760)
3048367 
* Update Banner to replace Unsplash image.

Replaces the Unsplash image with a CCO licensed image from Pxhere. Also
updates the CTA button to link to the Shop page, by default.

* Remove extra padding from top of test column.

Vertical alignment was off on the text column due to 60px of top
padding. This aligns everythign, as expected.
@albarin
Update Chessboard pattern images (#9761)
2198599
@albarin
Updathe the Hero Product Split (#9762)
9146775
@albarin
Remove unused pattern image (#9763)
820e932
@danielwrobert @imanish003
Update Images for the Product Details Patterns (#9764)
96a90c7 
* Update image for the Product Hero pattern.

Replace the Unsplash image with a CCO licensed image from Pxhere.

* Update images for Prod List Gallery Desc pattern

Replace the Unsplash image with a CCO licensed image from Pxhere for the
Product Listing with Gallery and Description pattern.

* Remove unneeded Unsplash images.

* Update copy for Prod Listing Gallery Desc pattern.

* Optimize new image exports.

* Update image for the Product Listing pattern.

Replace the Unsplash image with a CCO licensed image from Pxhere.

* Update images for Product Details pattern.

Replace the Unsplash images with CCO licensed images from Pxhere.

* Remove unneeded Unsplash image.

* Use Relative URLs for Images in the Product Listing Pattern

This commit replaces hardcoded URLs with dynamic ones for image placeholders in the `product-listing-with-gallery-and-description.php` pattern file.

- The `plugins_url()` function is now used to generate URLs, which correctly points to the images folder within the WooCommerce Blocks plugin directory. This approach provides better flexibility and portability since it doesn't rely on a specific domain or path. The `esc_url()` function is used to ensure the URL is safe to use in the HTML context.

- The change is made for a total of four images in the pattern.

---------

Co-authored-by: Manish Menaria <[email protected]>
@roykho @danielwrobert
Update/patterns featured category product collection (#9765)
284ecb0 
* Update image for featured category focus pattern

* Update image for featured category cover image pattern

* Update images for featured category triple pattern

* Change to wide width

* Update links to buttons

* Fix typo in hex color value.

There was an extra `f` in the hex color value, causing the text to
unexpectedly render black.

---------

Co-authored-by: Daniel W. Robert <[email protected]>
@roykho
Update/collection pattern images (#9766)
4662d8e 
* Update featured collections images

* Add shop link to shop by price pattern
@albarin
Update hero product pattern title (#9769)
96ff235
@albarin
Remove unused pattern image (#9770)
2b2b759
Merge remote-tracking branch 'origin/release/10.4.2' into release/10.4.2
4b11102
@github-actions
Copy link
Contributor Author

github-actions bot commented Jun 12, 2023 •
edited
Loading

The release ZIP for this PR is accessible via:

https://wcblocks.wpcomstaging.com/wp-content/uploads/woocommerce-gutenberg-products-block-9784.zip

Script Dependencies Report

There is no changed script dependency between this branch and trunk.

This comment was automatically generated by the ./github/compare-assets action.

TypeScript Errors Report

  • Files with errors: 469
  • Total errors: 2256

⚠️ ⚠️ This PR introduces new TS errors on 7 files:

assets/js/base/components/summary/utils.js

assets/js/blocks/product-categories/block.js

assets/js/blocks/product-categories/edit.tsx

assets/js/blocks/product-categories/index.tsx

assets/js/blocks/reviews/all-reviews/edit.js

assets/js/blocks/reviews/all-reviews/index.js

assets/js/editor-components/grid-content-control/index.js

comments-aggregator

@github-actions
Copy link
Contributor Author

github-actions bot commented Jun 12, 2023 •
edited
Loading

Size Change: +238 B (0%)

Total Size: 1.1 MB

Filename Size Change
build/active-filters.js 7.47 kB +1 B (0%)
build/all-products.js 40.1 kB -1 B (0%)
build/all-reviews.js 7.84 kB -2 B (0%)
build/attribute-filter.js 13.2 kB -1 B (0%)
build/checkout.js 46.4 kB -2 B (0%)
build/customer-account.js 3.18 kB +1 B (0%)
build/featured-category.js 15.1 kB +1 B (0%)
build/legacy-template.js 6.71 kB +252 B (+4%)
build/mini-cart-contents.js 18.1 kB +1 B (0%)
build/price-filter.js 8.55 kB -1 B (0%)
build/product-add-to-cart.js 8.84 kB +2 B (0%)
build/product-best-sellers.js 8.35 kB -1 B (0%)
build/product-button.js 3.97 kB -1 B (0%)
build/product-collection.js 11.2 kB +1 B (0%)
build/product-image.js 4.14 kB +3 B (0%)
build/product-price.js 1.68 kB -1 B (0%)
build/product-results-count.js 1.66 kB -1 B (0%)
build/product-tag.js 9.01 kB -2 B (0%)
build/product-title.js 3.66 kB +1 B (0%)
build/reviews-by-category.js 12.1 kB -4 B (0%)
build/reviews-by-product.js 13.3 kB -2 B (0%)
build/single-product.js 11.1 kB -3 B (0%)
build/stock-filter.js 7.62 kB -1 B (0%)
build/wc-blocks-vendors.js 65 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size
build/active-filters-frontend.js 8.65 kB
build/active-filters-wrapper-frontend.js 7.61 kB
build/all-products-frontend.js 12 kB
build/attribute-filter-wrapper--stock-filter-wrapper-frontend.js 4.04 kB
build/attribute-filter-wrapper-frontend.js 4.29 kB
build/blocks-checkout.js 35.1 kB
build/breadcrumbs.js 2.13 kB
build/cart-blocks/cart-accepted-payment-methods-frontend.js 1.39 kB
build/cart-blocks/cart-cross-sells-frontend.js 254 B
build/cart-blocks/cart-cross-sells-products--product-price-frontend.js 2.92 kB
build/cart-blocks/cart-cross-sells-products-frontend.js 3.77 kB
build/cart-blocks/cart-express-payment--checkout-blocks/express-payment-frontend.js 5.17 kB
build/cart-blocks/cart-express-payment-frontend.js 720 B
build/cart-blocks/cart-items-frontend.js 301 B
build/cart-blocks/cart-line-items--mini-cart-contents-block/products-table-frontend.js 5.51 kB
build/cart-blocks/cart-line-items-frontend.js 1.06 kB
build/cart-blocks/cart-order-summary-frontend.js 1.27 kB
build/cart-blocks/cart-totals-frontend.js 308 B
build/cart-blocks/empty-cart-frontend.js 346 B
build/cart-blocks/filled-cart-frontend.js 656 B
build/cart-blocks/order-summary-coupon-form-frontend.js 1.63 kB
build/cart-blocks/order-summary-discount-frontend.js 2.13 kB
build/cart-blocks/order-summary-fee-frontend.js 273 B
build/cart-blocks/order-summary-heading-frontend.js 333 B
build/cart-blocks/order-summary-shipping-frontend.js 17.1 kB
build/cart-blocks/order-summary-subtotal-frontend.js 274 B
build/cart-blocks/order-summary-taxes-frontend.js 435 B
build/cart-blocks/proceed-to-checkout-frontend.js 1.38 kB
build/cart-frontend.js 29.9 kB
build/cart.js 45.1 kB
build/catalog-sorting.js 1.7 kB
build/checkout-blocks/actions-frontend.js 1.85 kB
build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js 4.7 kB
build/checkout-blocks/billing-address-frontend.js 1.19 kB
build/checkout-blocks/contact-information-frontend.js 2.04 kB
build/checkout-blocks/express-payment-frontend.js 1.14 kB
build/checkout-blocks/fields-frontend.js 332 B
build/checkout-blocks/order-note-frontend.js 1.14 kB
build/checkout-blocks/order-summary-cart-items-frontend.js 3.68 kB
build/checkout-blocks/order-summary-coupon-form-frontend.js 1.79 kB
build/checkout-blocks/order-summary-discount-frontend.js 2.29 kB
build/checkout-blocks/order-summary-fee-frontend.js 277 B
build/checkout-blocks/order-summary-frontend.js 1.27 kB
build/checkout-blocks/order-summary-shipping-frontend.js 17 kB
build/checkout-blocks/order-summary-subtotal-frontend.js 274 B
build/checkout-blocks/order-summary-taxes-frontend.js 436 B
build/checkout-blocks/payment-frontend.js 8.28 kB
build/checkout-blocks/pickup-options-frontend.js 4.85 kB
build/checkout-blocks/shipping-address-frontend.js 1.17 kB
build/checkout-blocks/shipping-method-frontend.js 2.63 kB
build/checkout-blocks/shipping-methods-frontend.js 6.4 kB
build/checkout-blocks/terms-frontend.js 1.56 kB
build/checkout-blocks/totals-frontend.js 361 B
build/checkout-frontend.js 32 kB
build/featured-product.js 15.3 kB
build/filter-wrapper-frontend.js 14.3 kB
build/filter-wrapper.js 2.39 kB
build/general-style-rtl.css 1.31 kB
build/general-style.css 1.31 kB
build/handpicked-products.js 8.04 kB
build/mini-cart-component-frontend.js 28.5 kB
build/mini-cart-contents-block/cart-button-frontend.js 1.73 kB
build/mini-cart-contents-block/checkout-button-frontend.js 1.73 kB
build/mini-cart-contents-block/empty-cart-frontend.js 362 B
build/mini-cart-contents-block/filled-cart-frontend.js 267 B
build/mini-cart-contents-block/footer-frontend.js 4.09 kB
build/mini-cart-contents-block/items-frontend.js 237 B
build/mini-cart-contents-block/products-table-frontend.js 593 B
build/mini-cart-contents-block/shopping-button-frontend.js 526 B
build/mini-cart-contents-block/title-frontend.js 1.9 kB
build/mini-cart-contents-block/title-items-counter-frontend.js 1.59 kB
build/mini-cart-contents-block/title-label-frontend.js 1.53 kB
build/mini-cart-frontend.js 2.72 kB
build/mini-cart.js 4.43 kB
build/price-filter-wrapper-frontend.js 6.75 kB
build/price-format.js 1.19 kB
build/product-add-to-cart--product-button--product-image--product-price--product-rating--product-sale-bad--49d3ecb2.js 250 B
build/product-add-to-cart--product-button--product-image--product-rating--product-title.js 151 B
build/product-add-to-cart-frontend.js 6.52 kB
build/product-button--product-image--product-price--product-rating--product-sale-badge--product-sku--prod--5bce0384.js 954 B
build/product-button-frontend.js 2.65 kB
build/product-categories.js 2.7 kB
build/product-category.js 9.37 kB
build/product-image-frontend.js 2.62 kB
build/product-new.js 8.65 kB
build/product-on-sale.js 8.69 kB
build/product-price-frontend.js 203 B
build/product-query.js 11.8 kB
build/product-rating-frontend.js 2.33 kB
build/product-rating.js 1.03 kB
build/product-sale-badge-frontend.js 1.79 kB
build/product-sale-badge.js 665 B
build/product-search.js 2.63 kB
build/product-sku-frontend.js 1.84 kB
build/product-sku.js 535 B
build/product-stock-indicator-frontend.js 2.03 kB
build/product-stock-indicator.js 730 B
build/product-summary-frontend.js 2.19 kB
build/product-summary.js 905 B
build/product-template.js 3.34 kB
build/product-title-frontend.js 2.21 kB
build/product-top-rated.js 8.91 kB
build/products-by-attribute.js 9.75 kB
build/rating-filter-frontend.js 21.4 kB
build/rating-filter-wrapper-frontend.js 6.2 kB
build/rating-filter.js 6.9 kB
build/reviews-frontend.js 7.18 kB
build/stock-filter-wrapper-frontend.js 2.98 kB
build/store-notices.js 1.69 kB
build/vendors--attribute-filter-wrapper--cart-blocks/order-summary-coupon-form--cart-blocks/order-summary--48e1e4bb-frontend.js 6.82 kB
build/vendors--attribute-filter-wrapper--cart-blocks/order-summary-shipping--checkout-blocks/billing-addr--d9f38f9d-frontend.js 4.21 kB
build/vendors--attribute-filter-wrapper--stock-filter-wrapper-frontend.js 5.11 kB
build/vendors--cart-blocks/cart-cross-sells-products--cart-blocks/cart-line-items--cart-blocks/cart-order--3c5fe802-frontend.js 5.26 kB
build/vendors--cart-blocks/cart-line-items--checkout-blocks/order-summary-cart-items--mini-cart-contents---233ab542-frontend.js 3.57 kB
build/vendors--cart-blocks/order-summary-shipping--checkout-blocks/billing-address--checkout-blocks/order--decc3dc6-frontend.js 19.4 kB
build/vendors--checkout-blocks/pickup-options--checkout-blocks/shipping-methods-frontend.js 8.25 kB
build/vendors--checkout-blocks/shipping-method-frontend.js 12.5 kB
build/vendors--price-filter-wrapper-frontend.js 2.2 kB
build/vendors--product-add-to-cart-frontend.js 7.26 kB
build/vendors--rating-filter-wrapper-frontend.js 5.11 kB
build/wc-blocks-data.js 22.4 kB
build/wc-blocks-editor-style-rtl.css 6.01 kB
build/wc-blocks-editor-style.css 6 kB
build/wc-blocks-google-analytics.js 1.56 kB
build/wc-blocks-middleware.js 933 B
build/wc-blocks-registry.js 3.15 kB
build/wc-blocks-shared-context.js 1.52 kB
build/wc-blocks-shared-hocs.js 1.75 kB
build/wc-blocks-style-rtl.css 27.9 kB
build/wc-blocks-style.css 27.9 kB
build/wc-blocks-vendors-style-rtl.css 1.96 kB
build/wc-blocks-vendors-style.css 1.96 kB
build/wc-blocks.js 3.69 kB
build/wc-payment-method-bacs.js 816 B
build/wc-payment-method-cheque.js 811 B
build/wc-payment-method-cod.js 909 B
build/wc-payment-method-paypal.js 837 B
build/wc-settings.js 2.6 kB
build/wc-shipping-method-pickup-location.js 30.4 kB
build/woo-directives-runtime.js 2.73 kB
build/woo-directives-vendors.js 7.91 kB

compressed-size-action

@tarunvijwani tarunvijwani requested a review from kmanijak June 12, 2023 06:59
Tarun Vijwani and others added 7 commits June 12, 2023 13:43
Add 9769 PR testing steps
3b66f89
@thealexandrelara
WooCommerce Classic Template block: Fix error on clearing customizati…
cc57b39 
…ons on Woo Templates (#9759)

* Fix Classic Template block error on clearing customizations on template

* Add link to issue in JS Doc
@kmanijak
Change the way of debug check of tests-mysql container (#9794)
9748294
@kmanijak
Add alt text to images used in patterns describing their purpose (#9788)
4be8e42 
* Add alt text to images used in patterns describing their purpose

* Replace 1/3 notation with 1 out of 3, so it's better handled byt screen readers
Update testing instructions to include 9759 PR
1ea18c9
Update zip to include 9759 PR
695197e
Remove 9759 PR from testing instructions
2886a75
kmanijak
kmanijak approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@kmanijak kmanijak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested following the testing steps 👍

@github-actions github-actions bot added this to the 10.5.0 milestone Jun 13, 2023
@tarunvijwani tarunvijwani mentioned this pull request Jun 13, 2023
Merged
@tarunvijwani tarunvijwani merged commit 63def1f into release/10.4.0 Jun 13, 2023
@tarunvijwani tarunvijwani deleted the release/10.4.2 branch June 13, 2023 15:18
@gigitux gigitux removed this from the 10.5.0 milestone Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kmanijak kmanijak kmanijak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kmanijak @gigitux @tarunvijwani @albarin @danielwrobert @roykho @thealexandrelara