This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Enable Single Product block #9714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
status: blocker
woocommercebot
requested review from
a team and
roykho
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
kmanijak
suggested changes
Jun 5, 2023
There was a problem hiding this comment.
I think you should also remove the PHP flag here.
Please also remove the entry from the docs section of features behind the feature flag here.
Also, Single Product block is available when npm run build, but I think npm run build:deploy determines the production build and then the Single Product block is not available (I presume, it's because of the PHP flag).
…ocks into add/enable-single-product-block
You're right! Thanks! I fixed with 91588ff. Also, I updated testing instructions. |
…woocommerce/woocommerce-blocks into add/enable-single-product-block
gigitux
force-pushed
the
add/enable-single-product-block
branch
from
01c3a1d to
e12ad70
Compare
kmanijak
approved these changes
Jun 5, 2023
tarunvijwani
added
the
type: enhancement
This was referenced Jun 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the Single Product block. Kudos to @thealexandrelara for working on this block in the last weeks! 🙇
Testing
Automated Tests
User Facing Testing
npm run build:deploy)add to cartbutton .WooCommerce Visibility
Performance Impact
Changelog