This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Make mini cart icon RTL on RTL sites in editor #9707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roykho
added
type: bug
woocommercebot
requested review from
a team and
kmanijak
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +605 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
kmanijak
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Tested with the RTL language and the icon is facing the correct direction. 💪
Note (separate issue): I did notice we are using two different cart icons.
I am not sure if this was intended. If not, then I can also add this fix along with this PR.
I'm not sure why is that, but I remember there was an idea to make this icon customizable by merchants, hence it might've been intended to have different icons (ref: pdnLyh-2xv-p2). But my personal opinion - I think it would make sense to unify them.
|
Bumping it to 10.5.0 release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9421
This PR fixes the issue with the mini cart icon where in RTL language sites, the icon was still facing right when it should face left.
Note (separate issue): I did notice we are using two different cart icons.
I am not sure if this was intended. If not, then I can also add this fix along with this PR.
Screenshots
Testing
User Facing Testing
Mini cartblock.Mini carticon to open the editor drawer.Mini carticon is facing left instead of right as seen in the screenshot above.WooCommerce Visibility
Changelog