This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 221
Blockified Single Product Template: avoid to add another group block on the editor side when the user creates a template for a specific product #9699
Merged
gigitux
merged 2 commits into
trunk
from
9662-blockified-single-product-template-there-are-two-groups-block-that-wrap-the-single-product-template
Jun 2, 2023
Merged
Blockified Single Product Template: avoid to add another group block on the editor side when the user creates a template for a specific product #9699
gigitux
merged 2 commits into
trunk
from
9662-blockified-single-product-template-there-are-two-groups-block-that-wrap-the-single-product-template
Jun 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on the editor side when the user creates a template for a specific product
gigitux
added
type: bug
The issue/PR concerns a confirmed bug.
skip-changelog
PRs that you don't want to appear in the changelog.
focus: template
Related to API powering block template functionality in the Site Editor
labels
Jun 2, 2023
woocommercebot
requested review from
a team and
danieldudzic
and removed request for
a team
June 2, 2023 12:39
The release ZIP for this PR is accessible via:
Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
danieldudzic
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works just fine :)
gigitux
deleted the
9662-blockified-single-product-template-there-are-two-groups-block-that-wrap-the-single-product-template
branch
June 2, 2023 13:59
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
focus: template
Related to API powering block template functionality in the Site Editor
skip-changelog
PRs that you don't want to appear in the changelog.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR when the user creates a template for a specific product, the Single Product Template is wrapped by two group blocks instead of one.
This happens because the creation of a template for a specific product is done via REST API. For fixing this issue, I added another check.
Fixes #9662
Testing
Automated Tests
User Facing Testing
Manage All Templates
button.Add New
.woocommerce
that wraps the entire template.woocommerce
that wraps the entire template.WooCommerce Visibility