This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Ensure aria-label is showing correct value based on setting #9672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roykho
added
type: bug
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +67 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
danieldudzic
approved these changes
May 31, 2023
|
@danieldudzic - great suggestions, I didn't know there were already existing code in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9645
This PR fixes the issue where the attribute
aria-labelis always displaying thetotal priceinformation even whenDisplay total pricesetting is false.Screenshots
Testing
User Facing Testing
.wc-block-mini-cart__buttonon themini cart block. Find thearia-label.X item(s) in cart, with the price. Hover over themini carticon and click on. Inspect the element again to ensure it is still displayingX item(s) in cart.mini cartsettings and switch it to showDisplay total price.aria-labelshould now show "X item(s) in cart, total price of Y".mini cartin the header and perform the same tests and ensure each instance of themini cartshows their ownaria-labelvalue depending on theDisplay total pricesettings.WooCommerce Visibility
Performance Impact
Changelog