This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix Mini-Cart block check to see whether a script has already been enqueued #9649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
type: bug
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Aljullu
force-pushed
the
fix/mini-cart-enqueued-scripts-check
branch
from
fed9b2a to
3e1e880
Compare
|
Size Change: 0 B Total Size: 1.09 MB ℹ️ View Unchanged
|
Good catch! I updated the PR description. |
roykho
approved these changes
May 30, 2023
Aljullu
added a commit
that referenced
this pull request
May 30, 2023
This was referenced May 30, 2023
Aljullu
added a commit
that referenced
this pull request
May 30, 2023
This was referenced May 30, 2023
Aljullu
added a commit
that referenced
this pull request
May 30, 2023
* Empty commit for release pull request * Empty commit for release pull request * Add 10.0.6 changelog * Update versions to 10.0.6 * Fix Mini-Cart block check to see whether a script has already been enqueued (#9649) * Add 10.0.6 testing steps * Partially uplift #9251 to 10.0.x (#9654) * Update testing ZIP --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]>
Aljullu
added a commit
that referenced
this pull request
May 31, 2023
Aljullu
added a commit
that referenced
this pull request
May 31, 2023
Aljullu
added a commit
that referenced
this pull request
Jun 1, 2023
* Empty commit for release pull request * Empty commit for release pull request * Add 10.2.2 changelog * Update versions to 10.2.2 * Fix Mini-Cart block check to see whether a script has already been enqueued (#9649) * Experiment: Replace style hooks coming from `@wordpress/block-editor` (#9251) * Replace all style hooks with useStyleProps hook * Remove border/color/spacing hooks * Style Props Hook * Make use of `change-case` package * Tidy up block wrappers * Attribute filter does not use frontend.ts nor styles within block * Remove frontend from filter blocks and unused styleprops usage * Tidy up variable names so its clearer attributes are not required specifically from blocks * Update assets/js/blocks/mini-cart/mini-cart-contents/inner-blocks/mini-cart-title-label-block/block.tsx Co-authored-by: Albert Juhé Lluveras <[email protected]> * Update assets/js/blocks/attribute-filter/block-wrapper.tsx Co-authored-by: Albert Juhé Lluveras <[email protected]> * Update assets/js/blocks/active-filters/block-wrapper.tsx Co-authored-by: Albert Juhé Lluveras <[email protected]> * Update assets/js/blocks/mini-cart/mini-cart-contents/inner-blocks/mini-cart-checkout-button-block/block.tsx Co-authored-by: Tom Cafferkey <[email protected]> * Update assets/js/blocks/rating-filter/block-wrapper.tsx Co-authored-by: Tom Cafferkey <[email protected]> * Update assets/js/blocks/stock-filter/block-wrapper.tsx Co-authored-by: Tom Cafferkey <[email protected]> * Update assets/js/blocks/price-filter/block-wrapper.tsx Co-authored-by: Tom Cafferkey <[email protected]> * Update assets/js/blocks/mini-cart/mini-cart-contents/inner-blocks/mini-cart-cart-button-block/block.tsx Co-authored-by: Tom Cafferkey <[email protected]> * Simplify styleprop * Styleprops simplify * Fix withFeaturedItem styles * Like the original hook, flatten props and combine with parsed styles --------- Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Tom Cafferkey <[email protected]> * Add 10.2.2 testing steps * Fix colors not being applied to Mini-Cart Proceed to Checkout Button in the editor (#9661) * Update 10.2.2 testing steps --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Mike Jolley <[email protected]> Co-authored-by: Tom Cafferkey <[email protected]>
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the fix we introduced in #9586 was causing some dependencies not to be loaded on WC 7.7.x. This PR should fix this.
Testing
User Facing Testing
Testing steps for internal testers only
This is to test the same fixes with WC 10.0.x:
release/10.0.5:git checkout release/10.0.5.npm run change-versionsand set the new version to 10.0.6.git cherry-pick 3e1e880798aea9c4b673fcb02356c802112d05d0.WooCommerce Visibility
Changelog