Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Remove propTypes definitions from Product List container #9616

Merged
merged 2 commits into from
May 28, 2023

Conversation

hritikchaudhary
Copy link
Contributor

Fixes #9548

Changes in the PR:

Removed propTypes definitions from Newest Products block, price filters, add-to-cart and product-list block.

Testing

Automated Tests

  • Changes in this PR are covered by Automated Tests.
    • Unit tests
    • E2E tests

User Facing Testing

  • Do not include in the Testing Notes

WooCommerce Visibility

  • WooCommerce Core
  • Feature plugin
  • Experimental

@nielslange nielslange self-requested a review May 27, 2023 15:23
Copy link
Member

@nielslange nielslange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @hritikchaudhary. The changes look good, and all CI check on #9617 are green. I'll merge this PR now.

Thanks again for this improvement! 🙌

@nielslange nielslange merged commit caa1243 into woocommerce:trunk May 28, 2023
@tarunvijwani tarunvijwani added this to the 10.4.0 milestone Jun 5, 2023
@tarunvijwani tarunvijwani added the type: bug The issue/PR concerns a confirmed bug. label Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug The issue/PR concerns a confirmed bug. type: community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace propTypes with TypeScript definitions
3 participants