This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Migrate Classic Block E2E tests to Playwright #9575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
changed the title
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
assets/js/base/components/state-input/billing-state-input.tsx
assets/js/base/utils/address.ts |
|
Size Change: 0 B Total Size: 1.09 MB ℹ️ View Unchanged
|
gigitux
force-pushed
the
add/enable-blockified-template-e2e-tests
branch
from
f870b34 to
438cdfe
Compare
gigitux
added
focus: template
gigitux
force-pushed
the
add/enable-blockified-template-e2e-tests
branch
3 times, most recently
from
d845beb to
f3ced25
Compare
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
gigitux
force-pushed
the
add/enable-blockified-template-e2e-tests
branch
from
1ca38b6 to
87a5476
Compare
gigitux
force-pushed
the
add/enable-blockified-template-e2e-tests
branch
4 times, most recently
from
73e586a to
fe792be
Compare
gigitux
force-pushed
the
add/enable-blockified-template-e2e-tests
branch
from
fe792be to
fcfbf75
Compare
…able-blockified-template-e2e-tests
…able-blockified-template-e2e-tests
…thub.com/woocommerce/woocommerce-blocks into add/enable-blockified-template-e2e-tests
10 tasks
…github.com/woocommerce/woocommerce-blocks into add/enable-blockified-templates-as-default
…github.com/woocommerce/woocommerce-blocks into add/enable-blockified-template-e2e-tests
gigitux
force-pushed
the
add/enable-blockified-templates-as-default
branch
from
cf7c11f to
504507f
Compare
…able-blockified-template-e2e-tests
…able-blockified-template-e2e-tests
roykho
reviewed
May 30, 2023
roykho
reviewed
May 31, 2023
| @@ -213,7 +230,7 @@ describe( `${ block.name } Block`, () => { | |||
|
|
|||
| await insertBlock( 'Products (Beta)' ); | |||
| await insertBlock( block.name ); | |||
| await page.waitForNetworkIdle(); | |||
| // await page.waitForNetworkIdle(); | |||
There was a problem hiding this comment.
We can probably remove this line.
There was a problem hiding this comment.
Removed with 6e39326
* migrate classic block to Playwright * fix can be inserted more than once tests * migrate classic block to Playwright * fix command * remove old tests * improve E2E tests * skip test * Products block: add E2E pw tests * Add E2E tests * fix E2E test * test now * try now * rename path * set one worker * try now * try now * try now * set 1 worker
gigitux
added a commit
that referenced
this pull request
Jun 1, 2023
* Enable blockified templates * add html template * fix function * WIP * Migrate Classic Block E2E tests to Playwright (#9575) * Add E2E tests * add comment * set worker to 1 * try now * add beforeAll and afterAll hook * restore woocommerce-gutenberg-products-block.php * enable plugin with .wp-env configuration * remove waitForNetworkIdle * Products block: Add e2e tests (#9577) * migrate classic block to Playwright * fix can be inserted more than once tests * migrate classic block to Playwright * fix command * remove old tests * improve E2E tests * skip test * Products block: add E2E pw tests * Add E2E tests * fix E2E test * test now * try now * rename path * set one worker * try now * try now * try now * set 1 worker
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Playwright project to run E2E tests with global side effects. Due to the nature of these tests and their potential impact, they are not executed in parallel with other tests (see #9632).
Also, it adds Playwright tests to be sure that the Classic Template Block is rendered by default when
wc_blocks_use_blockified_product_grid_block_as_templateoption is set to false.It removes some tests from Puppeteer. They tested some Site Editor functionalities, but E2E tests about the classic block should not test Gutenberg logic.