This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Allow Shipping method prices to inherit global styles text color #9456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the hardcoded color for Shipping method prices
woocommercebot
requested review from
a team and
mikejolley
and removed request for
a team
May 12, 2023 18:48
tarunvijwani
added
status: needs review
type: bug
The issue/PR concerns a confirmed bug.
focus: global styles
Issues that involve styles/css/layout structure.
labels
May 12, 2023
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: -5 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
mikejolley
approved these changes
May 15, 2023
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
May 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
focus: global styles
Issues that involve styles/css/layout structure.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shipping method prices had fixed color that was unreadable on some background colors.
With this PR, we're allowing Shipping method prices to inherit global styles text color.
Fixes #9192
Changes in the PR
Accessibility
prefers-reduced-motion
Other Checks
Screenshots
Testing
Automated Tests
User Facing Testing
Steps to reproduce the behavior:
WooCommerce Visibility
Performance Impact
Changelog