This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update pattern with images and alignment #9414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roykho
added
skip-changelog
|
Noting this should skip testing as this PR is just to fix unreleased changes from #9340 |
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
imanish003
approved these changes
May 10, 2023
kmanijak
reviewed
May 10, 2023
|
@imanish003 - yes that is intentional because if you read my comment above, this is just a fix for an already existing addition to the pattern #9340 which has the sprints and epics. We don't want to have duplicate PRs in this context. @kmanijak - yes that is also intentional because there may be several rounds of changes and it became very tedious to indent them every time we made a change. So I think we could do that later when everything is settled to all patterns at once. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9269
This PR converts the work from above PR that was initially using the product category blocks into using WP core blocks.
Screenshots
Testing
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog