This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update pattern alignments #9410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
roykho
added
the
skip-changelog
|
Leaving a note to not include this PR testing as this is just updating the PR from #9373 which has the testing steps so we don't need to repeat here. |
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
nielslange
approved these changes
May 9, 2023
There was a problem hiding this comment.
Thanks for working on this, @roykho. The change looks great with all alignments! 🙌
Full width
|
Wide:
|
None:
|
roykho
force-pushed
the
update/shop-by-price-pattern
branch
from
c5e2796 to
f447ebf
Compare
kmanijak
pushed a commit
that referenced
this pull request
May 10, 2023
* Update pattern alignments * Add explicit margin * Try this * Explicitly set margins * Remove is-light class
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9107
This PR adds the
Shop by Pricepattern.Screenshots
Testing
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog