This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Only validate postcode if its required or filled #9377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
tarhi-saad
and removed request for
a team
senadir
added
type: bug
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +355 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
ralucaStan
added
the
status: blocker
nielslange
reviewed
May 8, 2023
There was a problem hiding this comment.
Thanks for working on this, @senadir.
Testing optional empty fields
While looking into the first test case Testing optional empty fields, I noticed that the postcode validation error still appeared when applying the following steps:
- Go to
/wp-admin/admin.php?page=wc-settingsand setDefault customer locationtoNo location by default. - Open an incognito window.
- Add a product to the cart.
- Go to the checkout page.
- Provide the following credentials
Email address: [email protected]
First name: Jaap
Last name: Schippers
Address: Main Road 23
Country/Region: Vietnam
Postal code (optional): KEEP EMPTY
City: Hanoi
Phone (optional): KEEP EMPTY
- Click on
Place Order. - See that postal code validation kicks in and inline error message
Please enter a valid postal codeis visible. - Refresh the page.
- Click on
Place Order. - See that the order can be placed now.
- Repeat steps 2. until 7. with a fresh incognito window.
- Instead of refreshing the window, add some characters in the postal code field and empty the field again.
- Click on
Place Order. - See that the order can be placed as well.
Testing optional filled fields
While looking into the second test case Testing optional filled fields, I saw the same behaviour as for the first test case. These are my testing steps for the second test case:
- Go to
/wp-admin/admin.php?page=wc-settingsand setDefault customer locationtoNo location by default. - Install and activate the plugin
Code Snippets. - Go to
/wp-admin/admin.php?page=add-snippetand add the following snippet:
add_filter(
'woocommerce_get_country_locale',
function( $locale ) {
$locale['GB']['postcode']['required'] = false;
return $locale;
},
10,
1
);- Ensure that the priority for the snippet is set to
1:
- Open an incognito window.
- Add a product to the cart.
- Go to the checkout page.
- Provide the following credentials
Email address: [email protected]
First name: Jaap
Last name: Schippers
Address: Main Road 23
Country/Region: United Kingdom (UK)
Postal code (optional): KEEP EMPTY
City: London
Phone (optional): KEEP EMPTY
- Click on
Place Order. - See that postal code validation kicks in and inline error message
Please enter a valid postal codeis visible. - Refresh the page.
- Click on
Place Order. - See that the order can be placed now.
- Repeat steps 2. until 7. with a fresh incognito window.
- Instead of refreshing the window, add some characters in the postal code field and empty the field again.
- Click on
Place Order. - See that the order can be placed as well.
ralucaStan
reviewed
May 8, 2023
| ) | ||
| field.required || inputObject.value | ||
| ? customValidationHandler( | ||
| inputObject, |
There was a problem hiding this comment.
I think these checks should be inside the customValidationHandler if possible. The customValidationHandler should receive another parameter isOptional, defaulted to false and should handle the logic inside.
tarunvijwani
approved these changes
May 9, 2023
kmanijak
pushed a commit
that referenced
this pull request
May 9, 2023
* Only validate postcode if its required * Clear postcode validation error if postcode is not required --------- Co-authored-by: Niels Lange <[email protected]>
kmanijak
added a commit
that referenced
this pull request
May 9, 2023
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are validating postcodes even if they're not required, in this PR, I change that so we only validate them if they're required or filled.
The filled check prevent adding invalid optional postcodes.
Fixes #9376
User Facing Testing
Testing optional empty fields
Testing optional filled fields
For this one we need a turn a required country to optional, this can, add this code to make the UK's postcode optional
Changelog