-
Notifications
You must be signed in to change notification settings - Fork 219
Add new Product listing with gallery
pattern
#9347
Conversation
The release ZIP for this PR is accessible via:
Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
@shaunandrews this is the closest I could get to your design, what do you think we can do? |
I like the new pattern based on the figma design but I think the blockified product template needs some adjustments.
|
Can we remove the quantity selector for the Add to Cart Button? Can we improve the Ratings block to allow for customization of the text? Having it yellow makes it incredibly hard to read. I'd love to have a real gallery available, but until the we have the block in a better place, could we showcase additional images using the WP Core Image Gallery block? Why is the price underlined? Is it a link or something? |
I was discussing this topic with @nerrad last week, and an alternative I'm exploring is to remove the restriction for the Add to Cart button block so it can be used within the Single Product block and not only as an inner block for the Products (Beta). This approach might be easier/faster than updating the Add to Cart From block to remove the quantity selector as that one is currently server-side rendered. Ref. pdnLyh-3xC-p2#comment-2443 |
@albarin considering the Single Product block is experimental at this point: should we rely on such block (available only on dev builds) for creating patterns? What do you think? |
Yes, I'll rebuild using normal blocks, not using the single product 👌 |
f7dba24
to
640cae8
Compare
@roykho Sorry, there was an issue with the images, updated the title as well. Thanks! |
I made some changes to make it work better with differents widths |
I tested this pattern included in the PR, however I'm not quite sure how to use it. |
@roykho thanks for the review and instructions, I think I fixed everything you mentioned 🙏 |
@tomxygen thanks for your feedback 🙏 To answer your question I'm quoting @nefeline on this other pattern PR #9383:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. In fullwidth there is no padding on the left/right side in mobile. But I don't think that is a blocker so approving for now.
This PR implements the
Product listing with gallery
pattern.Fixes #9110
Screenshots
Design
Testing
User-Facing Testing
Product listing with gallery
pattern appears under the WooCommerce category dropdown.WooCommerce Visibility
Changelog