This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Mini Cart drawer: print width in PHP #9329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
type: bug
woocommercebot
requested review from
a team and
roykho
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -27 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
|
In testing this, even without this change it seems the drawer is opening "instantly" as well? I am doing hard refresh on each test as well. Here is what it looks like for me in |
Good point, I should have clarified that. The delay is only reproducible if some of the dependencies are still loading, that might only be reproducible the first time the page is loaded and if the network is slow. After that, the dependencies are already loaded so it opens instantly. I added that in the testing steps. |
Aljullu
force-pushed
the
fix/drawer-missing-width
branch
from
9abe48e to
6b79d8a
Compare
|
Btw, I noticed this is causing issues in classic themes (that's why tests are failing). I'm currently investigating it. 🕵️ |
Aljullu
force-pushed
the
fix/drawer-missing-width
branch
from
6b79d8a to
300fd35
Compare
Should have been fixed in 300fd35. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the logic to print
--drawer-widthfrom JS to PHP, this makes the value to be available before the React component is loaded, meaning the drawer can be visible earlier.This is a regression from #8930.
Testing
User Facing Testing
WooCommerce Visibility
Changelog