This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Fix Product Price styles leaking into the Mini Cart, Cart and Checkout blocks #9276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
type: bug
The issue/PR concerns a confirmed bug.
block: cart
Issues related to the cart block.
block: checkout
Issues related to the checkout block.
focus: global styles
Issues that involve styles/css/layout structure.
block-type: product elements
Issues related to Product Element blocks.
block: mini-cart
Issues related to the Mini-Cart block.
labels
Apr 28, 2023
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
April 28, 2023 10:10
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: +245 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
imanish003
approved these changes
May 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Aljullu, I have tested the changes, and it's working as expected. 🚀
I did come across one query during my review, but it's not a blocker and doesn't affect the overall functionality. Therefore pre-approving the PR. 🙌🏻
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: cart
Issues related to the cart block.
block: checkout
Issues related to the checkout block.
block: mini-cart
Issues related to the Mini-Cart block.
block-type: product elements
Issues related to Product Element blocks.
focus: global styles
Issues that involve styles/css/layout structure.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9044.
Testing
User Facing Testing
Product Price styles don't leak into the Mini Cart block
Product Price styles are still applied to the Single Product template
Product Price styles are still applied to the Products and All Products blocks
WooCommerce Visibility
Changelog