This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove min-height and padding for WP Button elements #9260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcafferkey
added
type: bug
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -9 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
Aljullu
reviewed
Apr 27, 2023
There was a problem hiding this comment.
Thanks for picking up this issue, @tjcafferkey! This is working well in the block themes I tested, but I noticed a small regression in Storefront. I commented it inline. 👇
Aljullu
approved these changes
Apr 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason there was some default styling for
min-heightandpaddingfor .wc-block-components-buttonelements.I'm not sure the context as to why these were added but with my testing I can't see that this PR introduces any obvious regressions around buttons.
Fixes #8587
Other Checks
Screenshots
Before
After
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Changelog