This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add new Product collections: Featured Collection pattern
#9246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albarin
added
type: enhancement
woocommercebot
requested review from
a team and
Aljullu
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +142 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
Aljullu
reviewed
Apr 26, 2023
There was a problem hiding this comment.
Overall it looks good, just a couple of comments:
- The text is dark for me with TT3 default styling, that means that contrast is quite low. Can you reproduce it too?
- There seems to be too much padding around the price/product name. That's also with TT3 default styling.
Aljullu
reviewed
Apr 27, 2023
There was a problem hiding this comment.
Now with Pilgrimage style variation, the price text is dark, making it have low contrast as well:
I think that if we are hard-coding the background color, we should do the same with text color (I guess to #fff?). Otherwise, there will always be cases where the theme has a color combination that doesn't work with our background.
Yes, you are right, I just pushed the change 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
Product Collections: Featured Collectionpattern.Fixes #9105
Screenshots
Design
Testing
User-Facing Testing
Product Collections: Featured Collectionpattern appears under the WooCommerce category dropdown.WooCommerce Visibility
Changelog