This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
[Pattern] Add new Hero product chessboard pattern
#9180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +9.69 kB (+1%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
albarin
added
type: enhancement
woocommercebot
requested review from
a team and
gigitux
and removed request for
a team
|
Great work! I have a couple of questions: On the editor side, I'm seeing a "Write title" text in front of the images: is that expected?
I'm seeing the button color matching my theme's: is that expected, or should it be black by default when using this pattern?
|
|
Adding one extra comment here as I just noticed the "Shop Now" button is not linking on any page by default: is that expected? One idea could perhaps be for us to link it to the shop page by default instead of leaving it blank. Screen.Recording.2023-04-28.at.14.05.53.mov |
|
@nefeline Thanks for the review 🙏
That's because I'm using the
That's right, I'm not sure about that, maybe @shaunandrews can decide here. I thought it should follow the style of all other buttons, also if the theme has a dark background and the button is black it may not be very visible.
Good catch, I forgot to add it, just pushed the change. Also, I changed the padding to use |
albarin
changed the title
Hero product chessboard patternHero product chessboard pattern
nefeline
approved these changes
May 8, 2023
There was a problem hiding this comment.
That's right, I'm not sure about that, maybe @shaunandrews can decide here. I thought it should follow the style of all other buttons, also if the theme has a dark background and the button is black it may not be very visible.
👍
Good catch, I forgot to add it, just pushed the change.
Also, I changed the padding to use px otherwise the size varies when changing themes/styles and it does not look good, it happened in other patterns I already merged.
👍
Awesome work! I'm pre-approving, just left a comment regarding block types in the docblock.
| * Title: Hero Product Chessboard | ||
| * Slug: woocommerce-blocks/hero-product-chessboard | ||
| * Categories: WooCommerce | ||
| */ |
There was a problem hiding this comment.
should we add the Block Types: being used on this pattern, the same way as other patterns in our repo do?
There was a problem hiding this comment.
Not sure if it's really useful for this pattern since it's not designed for a specific template part 🤔
I'll merge and if necessary we can always add it later.
Thanks 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
Footer with Simple Menu and Cartpattern.Fixes #9041
Screenshots
Design
Implementation
Testing
User-Facing Testing
Hero product chessboardpattern appears under the WooCommerce category dropdown.WooCommerce Visibility
Changelog