This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
[Patterns] Add new Footer with 3 menus menu
#9175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +38 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
woocommercebot
requested review from
a team and
Aljullu
and removed request for
a team
albarin
added
type: enhancement
albarin
changed the title
Footer with 3 menus menuFooter with 3 menus menu
Aljullu
reviewed
Apr 24, 2023
There was a problem hiding this comment.
Overall it looks good, just a few comments:
If the menus have only two items, the layout looks a bit weird:
I don't know if that's possible, but I think ideally every column should be aligned to the top (except the Powered by... text, which should be aligned to the bottom). 🤔
I'm not sure about this one, but in my site, the pattern didn't have any padding by default when added, so it was next to the window sides. I wonder if we should check this option from the wrapping Group:
|
@Aljullu thanks! I've added paddings and aligned the menus to the top 🙌 |
Aljullu
reviewed
Apr 24, 2023
There was a problem hiding this comment.
Thanks for updating the PR, @albarin!
Just a couple more things I noticed:
- It looks like the
Powered by WordPressstring is translated in WP core patterns. Do you know if we could do the same with thePowered by WordPress with WooCommercestring?
- The other thing is that I wonder whether we should add some top/bottom padding as well. 🤔 That would help when the footer gets a background color. I don't have a strong opinion and that's more like a design decision, so feel free to ignore it if you think it's a bad idea.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
Footer with 3 menuspattern.Fixes #9055
Screenshots
Design
Implementation
Testing
User-Facing Testing
Footer with 3 menuspattern appears under the WooCommerce category dropdown.WooCommerce Visibility
Changelog