Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

fix/8363: Match editor "Place Order" button UI with frontend #9094

Merged
merged 4 commits into from
Apr 19, 2023

Conversation

iamdharmesh
Copy link
Member

PR makes changes in the checkout actions block to match the "Place Order" button UI with the front end.

Fixes #8363

Accessibility

Other Checks

  • This PR adds/removes a feature flag & I've updated this doc.
  • This PR adds/removes an experimental interfaces and I've updated this doc.
  • I tagged two reviewers because this PR makes queries to the database or I think it might have some security impact.

Screenshots

Before After
image image

Testing

Automated Tests

  • Changes in this PR are covered by Automated Tests.
    • Unit tests
    • E2E tests

User Facing Testing

  1. Checkout to this PR branch.
  2. Edit the "Checkout Block" page and Verify "Place Order" UI match with the front-end Place Order button UI.
  • Do not include in the Testing Notes

WooCommerce Visibility

  • WooCommerce Core
  • Feature plugin
  • Experimental

Performance Impact

Changelog

Match editor "Place Order" button UI with frontend

@nielslange nielslange self-requested a review April 19, 2023 08:21
@nielslange nielslange added type: bug The issue/PR concerns a confirmed bug. block: checkout Issues related to the checkout block. Contributor Day - H1 2023 labels Apr 19, 2023
Copy link
Member

@nielslange nielslange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for working on this, @iamdharmesh! 👏 I've successfully tested the PR using various block and non-block themes. I'll keep an eye on the tests, but I hope I can merge this PR in the next hours. 🙌

@qasumitbagthariya
Copy link

qasumitbagthariya commented Apr 19, 2023

QA Update ✅


Testing Environment

  • WordPress: 6.2
  • Theme: Storefront 4.2.0
  • Theme: Storefront 1.3.0
  • Theme: Twenty Twenty-One 1.8
  • Theme: Twenty Twenty-Three 1.1
  • Theme: Twenty Twenty-Two 1.4
  • Woocommerce - 7.6.0
  • PHP: 8.0.21
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: Windows 11
  • Git Branch: testing

Theme - Storefront
image

image

Theme - Twenty Twenty-Three
image

image

Theme - Twenty Twenty-One
image

image

QA Status- Pass ✅

@mikejolley mikejolley mentioned this pull request Apr 19, 2023
@mikejolley
Copy link
Member

Tests are good, going ahead and merging this. Thanks @nielslange @qasumitbagthariya and @iamdharmesh

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: checkout Issues related to the checkout block. Contributor Day - H1 2023 type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Place order button is full width in the editor
4 participants