This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Single Product Template - Compatibility Layer: don't skip block without name #9075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
roykho
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
gigitux
force-pushed
the
9073-single-product-template-html-blocks-get-removed-after-blockified-upgrade
branch
from
373f311 to
7f7ce16
Compare
gigitux
force-pushed
the
9073-single-product-template-html-blocks-get-removed-after-blockified-upgrade
branch
from
7f7ce16 to
3c8745f
Compare
gigitux
added
type: bug
gigitux
changed the title
Aljullu
approved these changes
Apr 18, 2023
gigitux
removed
the
skip-changelog
Good point! I added the changelog and removed the label |
gigitux
deleted the
9073-single-product-template-html-blocks-get-removed-after-blockified-upgrade
branch
gigitux
added a commit
that referenced
this pull request
Apr 18, 2023
gigitux
added a commit
that referenced
this pull request
Apr 18, 2023
* Single Product Template - Compatibility Layer: don't skip custom HTML (#9075) * Fix: tax_query should be calculated only if __woocommerceAttributes is valid (#9049) This commit refactors the update_rest_query method in the ProductQuery.php file to improve code readability. It simplifies conditional expressions by introducing variables for clarity, and uses ternary operators to streamline the logic. * Blockfied Single Product Template: Add support for template for specific product (#9069) * Product Price Block: remove ProductSelector (#8980) * Empty commit for release pull request * Make Woo_Directive_Store PHP 7.3 compatible (#9033) * update version * add changelog * add testing instructions * update zip link file testing * Update docs/internal-developers/testing/releases/1001.md Co-authored-by: Albert Juhé Lluveras <[email protected]> --------- Co-authored-by: Luigi Teschio <[email protected]> Co-authored-by: Manish Menaria <[email protected]> Co-authored-by: github-actions <[email protected]> Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Single Product Compatibility Layer, adding support for custom HTML Blocks. When the Custom HTML is parsed, the result is a block without the name but with the
innerHTMLcontent.Currently, there is a check that cleans the blocks without a name, but with this PR, I removed this check.
Fixes #9073
Testing
Automated Tests
User Facing Testing
<h2>HTML Block here</h2>(or similar)WooCommerce Visibility
Changelog