This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
[Patterns]: Add new Featured Products 2 columns pattern
#9072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
albarin
changed the title
Featured Products 2 columns patternFeatured Products 2 columns pattern
woocommercebot
requested review from
a team and
nefeline
and removed request for
a team
nefeline
reviewed
Apr 21, 2023
albarin
force-pushed
the
8949/featured-products-b-w
branch
from
f4ae352 to
d0392b7
Compare
Ok, gotcha! Not something that we can solve on our end, but if previews are not available for Patterns, perhaps Gutenberg should not display it at all in such cases (or alternatively, add support for it), right? What are your thoughts? |
@nefeline Yeah, I'm not sure what's the logic behind that, also, I'm seeing 2 different types of previews 👇 the first one works fine but not the second: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
Featured products: 2 columnspattern.Fixes #8949
Screenshots
Testing
Automated Tests
User Facing Testing
Featured products 2 columnspattern appears under the WooCommerce category dropdown.WooCommerce Visibility
Changelog