This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Store API: allow searching by slug and include slug in the response
#9017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
albarin
added
type: enhancement
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
woocommercebot
requested review from
a team and
roykho
and removed request for
a team
roykho
reviewed
Apr 12, 2023
Thanks for the review! 🙌 |
|
Yay! I had a branch fixing this that I never got it to PR. Thank you for fixing it :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds multiple improvements to the Store API:
/wc/store/v1/products/:slugslugfrom/wc/store/v1/productsand/wc/store/v1/products/:id/wc/store/v1/products?slug=first-slug,second-slugFixes #8985
Testing
Automated Tests
User Facing Testing
/wc/store/v1/productsand check the returned json includes the productslug./wc/store/v1/products/:id(where:idis the ID of a product in your site) and check the returned json includes the productslug./wc/store/v1/products/:slug(where:slugis the slug of a product in your site) and check the product is returned and the returned json includes the productslug.WooCommerce Visibility
Changelog