This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Trigger the set-billing-address when editing Shipping and useShippingAsBilling is true #8841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senadir
added
type: enhancement
woocommercebot
requested review from
a team and
mikejolley
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +16 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
|
@senadir I moved this PR's milestone to 10.0.0 since it was not included in the last release but was marked as that milestone. |
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
|
Bumping to 10.1.0 after p1681129771372729/1681128388.500929-slack-C02UBB1EPEF |
github-actions
bot
removed
the
status: stale
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
|
@senadir do you have plans to merge this PR soon? |
github-actions
bot
removed
the
status: stale
|
WooCommerce Blocks 10.1.0 will be released soon. I'm bumping this PR to the next milestone |
|
PR bumped to the next milestone (10.3.0) |
mikejolley
approved these changes
May 22, 2023
|
I think this can has been kicked enough—I'll get it merged. |
mikejolley
force-pushed
the
add/trigger-billing-event-on-shippin
branch
from
fbf96ed to
7328e9b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this problem as part of working on the Klaviyo integration, we have a couple of events, set-billing-address and set-shipping-address, we trigger those whenever shipping or billing address changes, we didn't trigger the billing event in the shipping form, but we did the reverse, this fixes it.
Testing
Use same address for billingWooCommerce Visibility
Changelog