This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Mini-cart: add the option to change the style between 'Outline' and 'Fill' in all the buttons #8835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +529 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
albarin
changed the title
albarin
changed the base branch from
trunk
to
8736/add-styles-to-mini-cart-buttons
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
albarin
force-pushed
the
8787/button-outline-settings
branch
from
dd2e1a9 to
6ed0afa
Compare
imanish003
reviewed
Mar 24, 2023
...s/js/blocks/mini-cart/mini-cart-contents/inner-blocks/mini-cart-cart-button-block/block.json
Show resolved
Hide resolved
imanish003
reviewed
Mar 24, 2023
imanish003
reviewed
Mar 24, 2023
There was a problem hiding this comment.
Great job, @albarin! 🙌🏻
I have some minor suggestions that I would like to share.
imanish003
approved these changes
Mar 24, 2023
albarin
added
type: enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
Fill&Outlinestyles to the 3Mini-cartbuttons.Fixes #8787
Testing
User-Facing Testing
Mini cartblock to the header template of your site.Site Editorand edit theMini carttemplate part.List viewand select theEmpty Mini Cart view.Start shoppingbutton, check that you can change the button style betweenFillandOutlinein the sidebar settings and change it from the default and save.Filled Mini Cart viewand theView my cartand theGo to checkoutbuttons.WooCommerce Visibility
Changelog