This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix issue that prevented spaces being added to Mini Cart, Cart and Checkout buttons #8777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
type: bug
woocommercebot
requested review from
a team and
thealexandrelara
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +718 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
albarin
approved these changes
Mar 17, 2023
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Aljullu
added
the
release: cherry-pick
Aljullu
added a commit
that referenced
this pull request
Mar 22, 2023
…eckout buttons (#8777) * Fix issue that prevented spaces being added to Mini Cart, Cart and Checkout buttons * Fix a couple of comments
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8734.
This PR:
EditableButton) that can be used to replace buttons containing aRichTextcomponent. They were used in the editor side of the Mini Cart, Cart and Checkout blocks to customize the text of the buttons.contenteditableelements inside buttons (see Firefox bug). Ideally, when the bug is fixed in Firefox, we should be able to remove this work-around.Testing
User Facing Testing
WooCommerce Visibility
Changelog