This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Mini-cart: add setting to not render the block on the cart & checkout pages #8700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albarin
added
type: enhancement
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/mini-cart/edit.tsx
|
|
Size Change: -960 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
Aljullu
reviewed
Mar 10, 2023
There was a problem hiding this comment.
I left a couple of comments in the code, but overall LGTM. I also tested it and it works perfectly. 👌
@pmcpinto @Aljullu do you have any suggestions for the toggle options and description copy?
It's a tricky one. An alternative would be to name the two options as "invisible" and "hidden", but I don't know if it makes things any easier to understand. Or to replace Don't render with Don't display.
Another option would be to use the explanation text below the toggle to explain what each options does. We seem to do it in some blocks, but I'm not sure if it's a correct GB pattern. 😕
Enregistrament.de.pantalla.des.de.2023-03-10.14-13-45.webm
More thoughts: what about
Yeah, that'd be useful, but I remember I changed that behavior some time ago on another toggle, so maybe it's something we are trying to avoid, not sure; |
In the future we may want to add more rendering styles, so a boolean wasn't the best option, a string will allowed us more than two options
I was going to suggest this as an alternative :) |
Aljullu
approved these changes
Mar 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
Mini Cartis hidden with CSS on the Cart & Checkout pages. As discussed on #7760 we want to give the users the option to not render it at all (not only hide it).This PR add this setting to the
Mini Cartblock and does not render the block when enabled. The default setting is to render it invisible (same behavior as until now) to not affect existing stores.Fixes #7760
Screenshots
Testing
User-Facing Testing
Site Editor
Mini Cartblock. Save.Hide.Mini Cartis rendered but invisible. Repeat but for the Checkout page.Mini Cartsetting toRemove, and save.Mini Cartmarkup is not rendered at all. Repeat but for the Checkout page.Post/page
Mini Cart.Mini Cart in cart and checkout pagessetting does not appear.WooCommerce Visibility
Changelog