This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add setting to Checkout block to control Hide shipping costs until an address is entered option #8680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
status: needs review
type: enhancement
woocommercebot
requested review from
a team and
wavvves
and removed request for
a team
opr
force-pushed
the
add/hide-costs-control
branch
from
92ed998 to
f0c1fe7
Compare
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/cart-checkout-shared/payment-methods/test/payment-methods.js
assets/js/blocks/cart/cart-line-items-table/cart-line-item-row.tsx assets/js/blocks/cart/inner-blocks/proceed-to-checkout-block/block.tsx assets/js/blocks/cart/test/block.js assets/js/blocks/checkout/inner-blocks/checkout-shipping-method-block/edit.tsx assets/js/blocks/checkout/inner-blocks/checkout-shipping-methods-block/edit.tsx assets/js/data/cart/reducers.ts assets/js/data/payment/utils/check-payment-methods.ts assets/js/editor-components/expandable-search-list-item/expandable-search-list-item.tsx assets/js/editor-components/product-attribute-term-control/index.js assets/js/editor-components/search-list-control/search-list-control.tsx assets/js/utils/attributes.ts packages/checkout/filter-registry/index.ts |
|
Size Change: +680 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
wavvves
reviewed
Mar 9, 2023
7 tasks
Required because importing from the index causes the validation data store to register twice
This reverts commit 9967dc0.
Update `wc/store/cart` to handle hidden shipping costs until address is entered
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on
remove/core-shipping-settings#8679 - I split it up to make the changes easier to review.This PR adds a control to the editor when selecting either the
Shipping Methodblock or theShipping Optionsblock. The control is used to change theHide shipping costs until an address is enteredoption, this was removed from WC Core in #8679 and is now a block option.The setting is present on two blocks, and changing it on one block will also affect the other block. This is achieved by the
updateAttributeInSiblingBlockfunction I added in f47cb95In 18af032 I also added a filter to override the
woocommerce_shipping_cost_requires_addressoption - this should always benoif the Checkout block is in use, because we will instead use the block control.This PR contains commit 92ed998 which will be reverted in the next PR. This commit was included to make the PR testable.
Screenshots
Testing
Automated Tests
User Facing Testing
Shipping MethodblockHide shipping costs until an address is enteredoption in the block sidebar.Shipping optionsblock, see the same option. Ensure the value is the same as what it was in step 4.truethen you should see the textShipping options will be displayed here after entering your full shipping address.instead of shipping options.Shipping Methodblock and toggle the option there. View theShipping optionsblock while toggling and ensure it changes.See loom for testing: https://www.loom.com/share/e28c4b49835b44d99a762aca14e80b7f
WooCommerce Visibility
Performance Impact
Changelog