This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
fix: Show sale bage on Product Image Gallery block #8652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
type: bug
gigitux
force-pushed
the
fix/8528-product-image-gallery-block-not-showing-sale-badge
branch
from
4994ee4 to
6b48d90
Compare
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +142 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
gigitux
force-pushed
the
fix/8528-product-image-gallery-block-not-showing-sale-badge
branch
from
6b48d90 to
af57923
Compare
There was a problem hiding this comment.
Thank you for working and solving the issue. There is one thing that I'd like to check with you before approving the PR.
Currently, we can have multiple Product Image Gallery blocks added to the page, so I added more than one to the page inside a Group block and I realized the Sale badges are stacking at the top (probably caused by the fact that the span.onsale class has a position: absolute), like this:
Do you think this is an issue we have to solve or it would be better to just limit to 1 the amount of product image gallery blocks that we can add to the page?
Great catch! For now, let's limit it to one! I think that we should do this for all blocks related to the Single Product template. Fixed via 97b6a72 |
…ocks into fix/8528-product-image-gallery-block-not-showing-sale-badge
thealexandrelara
approved these changes
Mar 8, 2023
gigitux
deleted the
fix/8528-product-image-gallery-block-not-showing-sale-badge
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Product Image Gallery block was not displaying the badge for a product that is on sale. This PR fixes this bug.
Fixes #8528
Testing
User Facing Testing
WooCommerce Visibility