This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add ExperimentalOrderLocalPickupPackages Slot/Fill
#8636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
status: needs review
category: extensibility
woocommercebot
requested review from
a team and
wavvves
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/checkout/inner-blocks/checkout-pickup-options-block/block.tsx
packages/checkout/components/order-local-pickup-packages/index.tsx |
|
Size Change: -3.52 kB (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
wavvves
previously approved these changes
Mar 7, 2023
opr
force-pushed
the
add/local-pickup-slot-fill
branch
from
dfea41a to
5029278
Compare
mikejolley
approved these changes
Mar 13, 2023
tarunvijwani
added
type: bug
tarunvijwani
added
the
type: enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on
add/local-pickup-selectIt adds a Slot/Fill in the
checkout-pickup-options-blockblock which can be used to render content below our pickup options.It also changes the existing
RadioControlin theCheckoutPickupOptionsBlockto aLocalPickupSelect- this is required because when WC Subs renders multiple packages, we need to show a title for the package.Follow up issue: woocommerce/woocommerce#42461
Fixes #7998
Other Checks
Testing
Automated Tests
User Facing Testing
Internal developer testing
pluginsdirectory runnpx @wordpress/create-block -t @woocommerce/extend-cart-checkout-block my-test-plugin- this will create a plugin calledMy test plugin. Activate this.my-test-plugin/src/js/index.jsand change therenderfunction on/around line 17 to this:By using our convenient local pickup option, you can come to our store and pick up your order. We will send you an email when your order is ready for pickup.text below the pickup options.WooCommerce Visibility
Dev note
In this release we added a new Slot/Fill to the Local Pickup area. The Slot/Fill is named
ExperimentalOrderLocalPickupPackagesand it can be used to output content below our local pickup options. To find out more about this Slot/Fill please refer to our available slot fills documentation.Changelog