This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Local Pickup: merge country and state into same field in location modal #8408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are merging the Country & State fields. So, we should get both default values
We merged both fields in the Pickup Location form modal We can see a similar example in `WooCommerce -> Settings -> General`
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +191 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
woocommercebot
requested review from
a team and
opr
and removed request for
a team
tarhi-saad
changed the title
mikejolley
suggested changes
Feb 17, 2023
There was a problem hiding this comment.
Code looks pretty solid - I have some feedback however and some issues that need resolving.
-
If you're already using the pickup locations (in my case I had a location for United States), the new select does not pickup that value. In my case it defaulted to Afganistan.
-
When you select a country/state the summary text uses the codes:
Do you think it's possible to show the full names?
- When you select a country without states the text field appears below the country. Perhaps it might be better above/before the country select.
Thats all!
opr
reviewed
Feb 23, 2023
|
Thank you, @opr and @mikejolley, for the review! I made the following updates:
I couldn't reproduce the bug you both mentioned! I thought maybe it was a backward compatibility issue, but I added a local pickup address while on the trunk branch, then switched to this branch, and the |
Did you populate the pickup location with a country without a state you can select, one you must type? E.g. choose United Kingdom and enter Cambs as the state/country. |
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
tarhi-saad
removed
the
status: stale
|
Hello, @mikejolley! 👋 As a follow-up to my last message via Slack: p1678344985194959/1678291671.432779-slack-C8X6Q7XQU, I implemented a fix for the following bug: Bug
FixI mentioned here some potential fixes: p1678344985194959/1678291671.432779-slack-C8X6Q7XQU. I choose eventually to default to the same country (e.g. |
tarhi-saad
deleted the
merge/#8025-local-pickup-country-state-into-same-field
branch
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the
CountryandStatefields into the same field in the local pickup modal inWooCommerce -> Settings -> Shipping -> Local pickup -> Pickup locations -> Add pickup locationSome countries have missing states in WooCommerce. If they are selected, we display a
Statetext field to add it manually.Fixes #8025
Accessibility
prefers-reduced-motionOther Checks
Screenshots
Testing
Automated Tests
User Facing Testing
Enable local pickupinWooCommerce -> Settings -> Shipping -> Local pickup -> General.Pickup locations, click onAdd pickup location. ThePickup locationmodal should opendone, then save changesShipping methodsection, selectLocal PickupPickup optionsStatetext field is displayed. Fill in the form and continue with the rest of the instructions.WooCommerce Visibility
Performance Impact
Changelog