This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update the incompatible gateways notice design #8365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
senadir
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/editor-components/external-link-card/index.tsx
assets/js/icons/stories/index.tsx |
|
Size Change: +371 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
tarhi-saad
added
block: cart
senadir
reviewed
Feb 6, 2023
| @@ -85,7 +85,7 @@ export function IncompatiblePaymentGatewaysNotice( { | |||
| key={ id } | |||
| className="wc-blocks-incompatible-extensions-notice__element" | |||
| > | |||
| { title } | |||
| • { title } | |||
There was a problem hiding this comment.
Shouldn't we use list styling instead of a dot? don't feel like you need to change this, just asking.
There was a problem hiding this comment.
By changing the display from the default display: list-item to flex, some properties of lists are lost (e.g., list-style-type). But, we can use the before CSS property instead! 🙌 I pushed the changes
tarhi-saad
deleted the
update/8238-incompatible-gateways-notice-design
branch
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We made an API and some design changes:
Alertcomponent's API. We added the possibility to set astatusFixes #8238
Accessibility
prefers-reduced-motionOther Checks
Screenshots
Testing
Automated Tests
User Facing Testing
CheckoutBlockCheckoutBlock. You should see a notice with the list of incompatible gateways in the right sidebar of the editor (i.e.,Settings -> Block). Ensure the notice's icon has a yellow color, and the list of gateways has bullet points (see image below):WooCommerce Visibility
Performance Impact
Changelog