This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Style Book: Fix Featured Product and Featured Category Blocks preview #8313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because by the time we reach this line, innerBlocks will be an empty array (or we wouldn't make it this far) and if nextBlocks contains ANY items it will, by definition be unequal, so a length check is simpler and more performant. Also we can remove the dependence on yet another lodash function by doing it this way.
…om/woocommerce/woocommerce-blocks into fix/products-by-category-stylebook
…ocks into fix/products-by-category-stylebook
gigitux
added
type: bug
woocommercebot
requested review from
a team and
kmanijak
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +15 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
kmanijak
approved these changes
Jan 27, 2023
There was a problem hiding this comment.
LGTM! Tests well.💪
And thanks for detailed testing steps - I wasn't aware of Style Book, so TIL!
I noticed that there are some additional commits displayed in the commits list. I assume you checked out from some other branch, while the original branch was squashed and merged, but I'm mentioning it in case that wasn't intended:
Anyway, approving 👍
|
The commits belong to this PR that it has been merged. Thanks for the review! I'm going to merge the PR 💪 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Style Book preview for the Featured Product and Featured Category Blocks.
Screenshots
Testing
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog