This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Style Book: Hide Filter blocks and Product Search block #8309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
type: bug
woocommercebot
requested review from
a team and
dinhtungdu
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -198 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
gigitux
changed the title
gigitux
removed
the
skip-changelog
|
Great work 🚀! Confirmed the filter and the search blocks are not displayed in the Style Book anymore. Just have a couple of minor notes regarding the PR description:
|
Thanks for the comment! I updated the description :) |
This was referenced Jan 30, 2023
nielslange
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hides:
Filter Blocks
Regarding the Filter Blocks, I explored another approach (#8295), but we realized that Style Book rendered the old version of those blocks with that approach. To fix this issue, we should wait that #47443 is fixed.
If we agree with this approach, we should create another issue to keep in mind that we are blocked by #47443.
Deprecated Product Search block
It is fine that we hide the Product Search Block. It is a deprecated block and is no longer visible in the editor inserter.
Fixes #8175
Fixes #8180
Testing
User Facing Testing
Attribute Filter,Stock Filter,Price Filter,Rating filter, andProduct Searchblocks aren't visible.cc @nefeline @Aljullu
WooCommerce Visibility
Changelog