This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Hide core/no-results as default in Product Query if WP <= 5.9
#8082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`core/no-results` was not available until WP 6.0.
sunyatasattva
added
type: bug
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +38 B (0%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
Aljullu
approved these changes
Jan 3, 2023
sunyatasattva
removed
the
skip-changelog
sunyatasattva
added a commit
that referenced
this pull request
Jan 4, 2023
`core/no-results` was not available until WP 6.0.
sunyatasattva
added a commit
that referenced
this pull request
Jan 5, 2023
* Empty commit for release pull request * Fix for Rating alignment when used in Products block and Classic Template (#8104) * Hide `core/no-results` as default in Product Query if WP <= 5.9 (#8082) `core/no-results` was not available until WP 6.0. * Update the readme * Add testing notes * Remove the “Products (Beta)” block from WP 6.0 or lower (#8112) * Remove the Products block from WP < 6.0 Too many APIs which are required for the Products block experience are just plainly unavailable in versions lower than 6.0. * Revert "Fix for Rating alignment when used in Products block and Classic Template (#8104)" This reverts commit 8af92ee. Co-authored-by: github-actions <[email protected]> Co-authored-by: kmanijak <[email protected]> Co-authored-by: Lucio Giannotta <[email protected]>
|
@sunyatasattva given that we are now restricting the Products block to WP 6.1 or higher (#8112), should we revert this PR? |
|
Sure, doing it together sounds good to me. 👍 Only heads-up that we will need this to be done before January 16th, when the next WC Blocks version will be released (which will be merged into WC core 7.4). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
core/no-resultswas not available until WP 6.0 we need to only add it to the default template for the Products (Beta) block if the WP version is sufficient.Fixes #8069
User Facing Testing
core/no-resultsblock by default.WooCommerce Visibility
Changelog