This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add Results Count block #8078
Merged
Add Results Count block #8078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmanijak
changed the title
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +1.73 kB (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
kmanijak
added
the
type: new block
… 404 error on the frontend
woocommercebot
requested review from
a team and
gigitux
and removed request for
a team
github-actions
bot
added
status: ready to merge
and removed
status: stale
Co-authored-by: Albert Juhé Lluveras <[email protected]>
dinhtungdu
reviewed
Jan 16, 2023
dinhtungdu
reviewed
Jan 17, 2023
Co-authored-by: Tung Du <[email protected]>
Co-authored-by: Tung Du <[email protected]>
nielslange
added
block: product results count
nielslange
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to add the new Product Results Count block as part of the blockifying the product archive template project.
It shows the total number of products and how many of them are displayed at the moment based on the global query.
It uses the
woocommerce_result_count()function to render the block on the front end.In the Editor it displays "Showing 1-X of X results".
Fixes #8060
Screenshots
Testing
Automated Tests
User Facing Testing
Expected: Product Results Count block is not available there
Expected: It displays "Showing 1-X of X results".
Classic Templateand addProductsblockProductsblock hasInherit query from templatesetting enabled (!)Expected: It displays "Showing 1-16 of 17 results". - depends on number of products your store has, numbers may differ, but it displays correct number of product that shows up in
ProductsblockProductsExpected: It displays "Showing 17-17 of 17 results". - depends on number of products your store has, numbers may differ, but it displays correct number of product that shows up in
ProductsblockWooCommerce Visibility
Changelog