This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
load all JSON translation files correctly #8034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senadir
added
type: bug
woocommercebot
requested review from
a team and
wavvves
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.01 MB ℹ️ View Unchanged
|
wavvves
approved these changes
Dec 28, 2022
tarhi-saad
approved these changes
Jan 2, 2023
imanish003
pushed a commit
that referenced
this pull request
Jan 3, 2023
Co-authored-by: Saad Tarhi <[email protected]>
imanish003
added a commit
that referenced
this pull request
Jan 4, 2023
* Empty commit for release pull request * Add changelog * Add testing notes * Fix a typo * load all JSON translation files correctly (#8034) Co-authored-by: Saad Tarhi <[email protected]> * Disable Rate Limiting when editing Blocks in admin (#7934) * Disable Rate Limiting for users who can edit posts To avoid limiting the number of edits in WP admin to our Woo Blocks, we need to disable rate limiting altogether. We simply disabled rate limiting for users who can edit posts! * Refactor rate limiting code * Fix disabled rate limiting bug for non admin users * Refactored applying rate limiting code. Co-authored-by: Paulo Arromba <[email protected]> * Update woocommerce-gutenberg-products-block.zip * Update ZIP file * Add screenshots to testing notes * Fix markdown linting issues * Bumping version strings to new version. Co-authored-by: github-actions <[email protected]> Co-authored-by: Manish Menaria <[email protected]> Co-authored-by: Seghir Nadir <[email protected]> Co-authored-by: Saad Tarhi <[email protected]> Co-authored-by: Paulo Arromba <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a superset #7995
While it's hard to fully reproduce this PR (because it touches translation side we might know where) it does indeed prevent a problem of translation not loading correctly, mainly around the express payment block.
As to why this works:
When webpack produces chunks, it sometimes produces shared files between several files, those files sometimes live in a different folder (shared chunk between Cart and Checkout but lives in Cart folder). In this case, Checkout will fail to load its translation. This PR fixes that.
It builds on Niels fix in which we were loading translation from an old place, kinda related.
Testing steps