-
Notifications
You must be signed in to change notification settings - Fork 219
Conversation
* Add `Sort by title` preset. * sorted, thanks @nerrad
…Products block (#7932) * Fix the incorrect layout of Rating and Price in Classic Template There were styles required in Rating Filter that were added globally and influenced the layout of Rating in Products block as well as Classic template. The styles were moved to the Rating Filter block
* Extend Filter by Stock Editor options with dropdown and single/multiple choice * Add dropdown implementation for Filter by Stock Status * Adjust font-sizes to the rest of the filters * Add tests to Filter by Stock: dropdown and list variants * Change test file extension from .js to .tsx, so it handles types as well * Add E2E test to Filter by Stock checking if display style can be toggled * When typing in Filter by Stock dropdown, handle the space so it highlights the suggestions * Change the name of the filter blocks in the test files * Remove unnecessary waiting step in E2E test for Filter by Stock toMatchElement waits for an element for 30s by itself, hence waitForSelector usage was removed * Improve the STOCK_STATUS_OPTIONS type handling * Extract onDropdownChange function instead of inline arrow function * Fix overlaping dropdown content with the wrapper when Filter by Stock was set to single
* Product Query: First attempt at adding patterns * Product Query: Update patterns and the default block template * Product Query: And new and update existing patterns * Product Query: Adjust layout of the Minimal Product Row pattern * Product Query: Update pattern names * Product Query: Polish spaces between blocks inside the patterns * Product Query patterns: Link product titles and improve spacing between product elements * Product Query patterns: Button font-size update * Product Query patterns: Center the pagination * Product Query patterns: Center the pagination for the default pattern * Product Query patterns: Remove an empty column * Product Query patterns: Remove an empty column from the product list with 1:1 images pattern
* Rename the setting section to match Filter by Attribute * Add Display Style toggle to the block settings * Set list as a default value of displayStyle for Filter by Rating * Add dropdown variant of Filter by Rating * Extend the Editor settings with selectType: single or multiple * Adjust the styles of a FormTokenField to other dropdown * Align Editor settings order and wording between Filter by Attribute and Rating * Fix the issue with cut off corners of dropdown borders * Provide translated screen reader messages and placeholder * Revert the label property, which is necessary to display checkbox list * Make classname for Rating component optional and remove styling in Filter by Rating * Cover the case when filter with zero products needs string methods for comparison * Handle Typescript errors and add ts-ignore annotations when necessary * Remove explicit key prop assignment in Rating component * Remove leftover property in type definition * Refactor JSX element extension with custom properties to more robust way with object copy * Filter by rating tests (#7845) * Filter by Rating tests: - List single - List multiple - Dropdown single - Dropdown multiple * Adjust the font-size of Filter by Rating dropdown to the rest of the filters * Fix E2E tests after the Editor settings label has been changed * Improve sorting in Filter by Rating dropdown With this change the order of options is always descending: in the chips, suggestions, active filters and URL * Change the name of the filter blocks in the test files * Prevent single dropdown input to overflow the wrapper The issue is fixed in three filters, hence a new shared styles file is created at the path assets/js/blocks/shared/styles/style.css * Remove the unused styles of active options in Filter by Rating Chosen options in Filter by Rating list have been bolded. That was the only filter that was doing it. Class was removed, but not the styles themselves which became obsolete. Removing the leftover styles then * Change the approach of shared styles to fix the dropdown issue in filters Instead of using direct classes, rewrite it to mixin and include in the filters * Fix the Filter by Rating with Products block The problem was with the Products block, that there was incorrect initial value of product ratings query * Align the logic of getting the filters from URL for Filter by Rating with Filter by Stock Co-authored-by: Luigi Teschio <[email protected]>
* Add Inherit Query from template option * Update label
* Product Elements: Fix block settings * Rating: Fix inactive star color * Product Rating: Fix color inheritance
* StyleAttributesUtils: Fix PHP notices and invalid CSS output. Closes #7899. * StyleAttributesUtils: Fix border radius and width support * StyleAttributesUtils: Fix border radius and border color support * StyleAttributesUtils: Include additional checks to deal with PHP warnings * StyleAttributesUtils: Improve the custom border array check
… including tax (#7832) * Update MiniCart.php Added an update to the '$cart_contents_total' variable on the 'get_cart_price_markup' function if $cart->display_prices_including_tax is active. Currently displaying wrong amount total on page load if items are already in the basket. * Update MiniCart.php Removed white spaces? * Update MiniCart.php Fixed IF statement * Remove whitespace at end of line Co-authored-by: Albert Juhé Lluveras <[email protected]>
Co-authored-by: Albert Juhé Lluveras <[email protected]>
Co-authored-by: Albert Juhé Lluveras <[email protected]>
Co-authored-by: Albert Juhé Lluveras <[email protected]>
Co-authored-by: Albert Juhé Lluveras <[email protected]>
Co-authored-by: Albert Juhé Lluveras <[email protected]>
* Remove feature flag from Products block * Remove Products block from feature flags documentation
Patch release stepsThe release pull request has been created! This checklist is a guide to follow for the remainder of the patch release process. You can check off each item in this list once completed.
Initial Preparation
Create the Testing Notes
Each porter is responsible for testing the PRs that fall under the focus of their own team. Shared functionality should be tested by both porters. This means that the Rubik porter will mostly test checkout blocks and Store API endpoints, while the Kirigami porter will test the product related blocks and Store API endpoints.
Update Pull Request description and get approvals
If this release is deployed to WordPress.org
After Deploy
Pull request in WooCommerce Core for Package updateThis only needs done if the patch release needs to be included in WooCommerce Core. Reviewing and merging the PR is your team's responsibility, except in the case of
Publish PostsYou only need to post public release announcements and update relevant public facing docs if this patch release is deployed to WP.org. Otherwise, you can skip this section.
🚀 This comment was generated by the automations bot triggered by the creation of the branch:
|
08e8402
to
25f2319
Compare
The release ZIP for this PR is accessible via:
|
Script Dependencies ReportThe
This comment was automatically generated by the |
TypeScript Errors ReportFiles with errors: 436
assets/js/atomic/blocks/product-elements/add-to-cart/edit.js
assets/js/atomic/blocks/product-elements/price/block.js assets/js/atomic/blocks/product-elements/rating/block.tsx assets/js/atomic/blocks/product-elements/rating/index.ts assets/js/base/components/block-error-boundary/index.tsx assets/js/base/components/cart-checkout/totals/shipping/has-shipping-rate.js assets/js/base/components/cart-checkout/totals/shipping/shipping-rate-selector.js assets/js/base/components/radio-control-accordion/index.js assets/js/base/components/reviews/review-list-item/index.js assets/js/base/components/reviews/review-list/index.js assets/js/base/components/reviews/review-sort-select/index.js assets/js/base/context/hooks/cart/use-store-cart-coupons.ts assets/js/base/context/hooks/use-checkout-notices.js assets/js/base/context/providers/cart-checkout/checkout-processor.js assets/js/base/context/providers/store-snackbar-notices/components/snackbar-notices-container.js assets/js/base/utils/errors.js assets/js/base/utils/render-frontend.tsx assets/js/blocks/cart-checkout-shared/payment-methods/payment-method-error-boundary.js assets/js/blocks/cart/block.js assets/js/blocks/cart/inner-blocks/proceed-to-checkout-block/edit.tsx assets/js/blocks/checkout/block.tsx assets/js/blocks/checkout/inner-blocks/checkout-actions-block/block.tsx assets/js/blocks/mini-cart/mini-cart-contents/inner-blocks/mini-cart-footer-block/block.tsx assets/js/blocks/mini-cart/mini-cart-contents/inner-blocks/mini-cart-shopping-button-block/edit.tsx assets/js/blocks/single-product/block.js assets/js/blocks/single-product/edit/index.js assets/js/blocks/single-product/edit/layout-editor.js assets/js/data/cart/controls.js assets/js/data/cart/test/resolvers.js assets/js/editor-components/edit-product-link/index.js assets/js/previews/cart.ts node_modules/@wordpress/element/node_modules/@types/react/index.d.ts packages/checkout/components/order-shipping-packages/index.js packages/checkout/components/store-notices-container/index.tsx |
Size Change: -144 B (0%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and confirmed that the Product Sku block is no longer throwing an error when the pattern is added. Everything renders to the Editor and Front-End, as expected.
LGTM! 🚀
Patch release
This is the patch release pull request for WooCommerce Blocks plugin
9.1.3
.Changelog
Communication
Prepared Updates
Please leave a comment on this PR with links to the following:
Release announcement (announcement post on developer.woocommerce.com published after release).
Happiness engineering or Happiness/Support (if special instructions needed).
Relevant developer documentation (if applicable).
Quality
Testing Instructions are included in this PR
Any performance impacts are documented.
🚀 This pull request was generated by the automations bot triggered by the creation of the branch:
release/9.1.3
. cc @gigitux