This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Disable HTML editing on dynamic blocks #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerrad
approved these changes
Aug 6, 2019
|
@nerrad I don't think so - there is nothing to edit, so any edits there wouldn't do anything on these blocks anyway. Thanks for the review! |
|
@mikejolley do you think we should cherry-pick this for 2.3? |
mikejolley
added
release: cherry-pick
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic blocks have no content until they are rendered on the server side, therefore they should not be HTML editable. The use of shortcodes was dropped in 2.2.
Fixes #800
Also fixes the case of
tabIndexintroduced in a previous merge.To test,