This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix overriding archive-product when saving a fallback template
#7975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
|
The release ZIP for this PR is accessible via: |
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
|
Size Change: 0 B Total Size: 1.01 MB ℹ️ View Unchanged
|
TypeScript Errors ReportFiles with errors: 431 🎉 🎉 This PR does not introduce new TS errors. |
Aljullu
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
LGTM, confirming it fixes the issue. Thanks @albarin!
By the way, I found another issue while following the testing steps of this PR: https://github.com/woocommerce/woocommerce-blocks/issues/7976. I don't think it's blocking because it's reproducible in trunk as well, but will you be able to take a look?
alexflorisca
added
type: bug
This was referenced May 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug happening when saving a template in the editor that was using the
archive-productfrom the DB as a fallback. I was causing to override thearchive-productrow on the DB, thus losing it as a fallback for the other templates using it also as a fallback.Testing
User Facing Testing
Site Editor(/wp-admin/site-editor.php?postType=wp_template), make sure you have no customizations on any template.Product Catalogtemplate, add some customization and save./shopand make sure you see the customization you just did.product-category/clothing/,/product-tag/music,color/red, depending on your store configuration).Product Catalogtemplate, meaning you see exactly the same customization you did on theProduct Catalog.Site Editor, click on one of the templates using the Catalog fallback (eitherProducts by Category,Products by Tag, orProducts by Attribute).Site Editorand make sureProduct Catalogstill has its original customization.Product Catalog./shopand make sure you see theProduct Catalogcustomization.WooCommerce Visibility
Changelog