This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Create stable action references in useForcedLayout to fix wp.com bug #7967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue on wp.com, where data store actions are patched by a tracking code. If any action on a data store is used inside a dependency array for a react hook, it will throw the code into an infinite loop. To prevent this, @senadir fix it by removing the dependencies from the array in #7367. This P2 (pca54o-4GY-p2) sums up the the problem and generated a discussion around it. Jarda proposed re-writing the code (pca54o-4GY-p2#comment-4658) using the wp/data
registry
rather than distructing the actions fromuseDispatch
. This PR does exactly that.Fixes #7637
Testing
User Facing Testing
I can't think of a robust way to test this, maybe @senadir knows a better way, but this is a smoke test:
assets/js/tracking.js
and copy and paste the contents of this fileWooCommerce Visibility
Performance Impact
Changelog