This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add "Product Hero 2 Column 2 Row" commerce adjacent pattern. #7814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: |
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
TypeScript Errors ReportFiles with errors: 428 🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 974 kB ℹ️ View Unchanged
|
Aljullu
requested review from
a team and
danieldudzic
and removed request for
a team
Aljullu
added
the
status: blocker
danieldudzic
approved these changes
Dec 5, 2022
|
LGTM! 👌 |
nerrad
force-pushed
the
add/patterns_product-hero-2col-2row
branch
from
2bc5ac4 to
7b65fe6
Compare
|
LGTM after the i18n updates ✅ |
Product Hero 2 Column 2 Row.
nerrad
force-pushed
the
add/patterns_product-hero-2col-2row
branch
from
7b65fe6 to
5de1901
Compare
|
wow !!! ;-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Product Hero 2 Column 2 Row" commerce adjacent pattern is a hero block that can be used as inspiration for merchants wanting to showcase the base selling points of a product with accompanying images as a 2-column, 2-row layout.
cc @vivialice for design review
NOTE: The frontend screenshots were with images that won't ship with this pattern.
Screenshots
The following screenshots were with the Twenty Twenty Three theme and the "Whisper" style.
Editor
Pattern preview in Editor
Desktop frontend
Mobile frontend
Tablet frontend
Other Checks
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog