Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix Jest missing webpack config #781

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Fix Jest missing webpack config #781

merged 1 commit into from
Jul 31, 2019

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Jul 30, 2019

In a previous PR we removed babel.config.js so Jest was failing because of missing Babel configuration.

This PR adds a transform to the config which loads the Babel config, as described here: jestjs/jest#1468 (comment)

How to test the changes in this Pull Request:

  1. Verify all tests pass when running npm run test.
  2. Verify Travis is green in this PR.
  3. Verify frontend.deps.json doesn't include lodash.

@Aljullu Aljullu added status: needs review tools Used for work on build or release tools. labels Jul 30, 2019
@Aljullu Aljullu added this to the 2.4 milestone Jul 30, 2019
@Aljullu Aljullu requested a review from a team July 30, 2019 16:00
@Aljullu Aljullu self-assigned this Jul 30, 2019
psealock
psealock approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@psealock psealock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and testing well. I couldn't find frontend.deps.json, but I confirmed the products category list component on the frontend does not include lodash on the window nor is it anywhere in frontend.js. 👍

@Aljullu
Copy link
Contributor Author

Aljullu commented Jul 31, 2019

@psealock thanks for the review!

I couldn't find frontend.deps.json

It's under build directory. I should have specified that in the PR. 😅

@Aljullu Aljullu merged commit cdad10d into master Jul 31, 2019
@Aljullu Aljullu deleted the fix/jest-webpack-config branch July 31, 2019 08:25
@Aljullu Aljullu mentioned this pull request Jul 31, 2019
Merged
Aljullu added a commit that referenced this pull request Aug 8, 2019
@Aljullu
Fix Jest missing webpack config (#781)
b2c5a8f
@Aljullu Aljullu mentioned this pull request Aug 8, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@psealock psealock psealock approved these changes

Assignees

@Aljullu Aljullu

Labels
tools Used for work on build or release tools.
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Aljullu @psealock @woocommercebot