This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add CartEventContext and dispatch events when pressing proceed to checkout button
#7809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: |
TypeScript Errors ReportFiles with errors: 436
assets/js/base/context/providers/cart-checkout/cart-events/test/index.tsx
assets/js/blocks/cart/inner-blocks/proceed-to-checkout-block/test/block.tsx |
|
Size Change: +934 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
opr
added
status: needs review
category: extensibility
rubikuserbot
requested review from
a team and
senadir
and removed request for
a team
opr
force-pushed
the
add/cart-event-context-trunk
branch
from
dd62544 to
c43994d
Compare
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
senadir
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Thank you for working on this Thomas. I think what this PR is missing is a why section? why do we want to trigger an event on what supposed to be a regular link transition between two pages? I think this button serves a different purpose than say Place Order which puts things into motion. I'm overall not opposing this PR, just trying to understand some valid use cases for this.
Do we also need to document this somewhere?
| > | ||
| { __( 'Proceed to Checkout', 'woo-gutenberg-products-block' ) } | ||
| </Button> | ||
| <div> |
There was a problem hiding this comment.
Was this extra div always here?
There was a problem hiding this comment.
No, good catch I don't know why that's here.
|
The release ZIP for this PR is accessible via: |
github-actions
bot
removed
the
status: stale
Thank you for the review, Nadir. @mikejolley and I spoke about this (the why) and for now I plan to leave this PR until the rest of the cart validation/error handling is finished. Once it is we can decide if we this PR. At that point I will be able to answer you better about why it's necessary. |
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
|
Closing because this is no longer needed, we are using snackbars to show quantity changes. This PR was supposed to handle the case where validation errors needed to show in the quantity input fields, but this is no longer required. |
opr
force-pushed
the
add/cart-event-context-trunk
branch
2 times, most recently
from
d5119bf to
97e3a32
Compare
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/base/context/providers/cart-checkout/cart-events/test/index.tsx
|
opr
force-pushed
the
add/cart-event-context-trunk
branch
from
9557d04 to
628ad57
Compare
|
Hey @opr is this back?
Whats the new status? |
|
@mikejolley it's from woocommerce/woocommerce#42648 - the button should not be disabled, but we should still catch and prevent the default action to proceed to checkout. The only way to do this is using this event/observer. |
|
@opr I tried your example but after hitting cancel it still redirected. Not sure if I did something wrong? |
|
@mikejolley Weird, I've updated the example in the PR body to add the registration function to the useEffect's dependencies. |
mikejolley
approved these changes
Jun 19, 2023
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-do of #7694 but it targets
trunkinstead.Testing
Automated Tests
Internal dev testing
woocommerce-blocks/assets/js/base/components/quantity-selector/index.tsx
Line 77 in aa78099
onProceedToCheckoutevent, and show a confirmation box. Pressing cancel will cause the observer to return an error object, this should abort the proceed to checkout aciton.confirmwill happen multiple times).User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog